This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Some warning fixes for bfd/*
- To: binutils at sources dot redhat dot com
- Subject: Some warning fixes for bfd/*
- From: Andreas Jaeger <aj at suse dot de>
- Date: Sat, 25 Aug 2001 18:13:58 +0200
Ok to commit?
FYI for getting prototypes I compiled the files with -aux-info
/tmp/t.X and extracted the prototypes from that file after removing
the first comment and then run this emacs command on a buffer that
contained only the prototypes from t.X that I needed:
(defun my-tidy-up ()
(interactive)
(beginning-of-buffer)
(replace-regexp " ?[a-z_]*);.*" "));" nil)
(beginning-of-buffer)
(replace-regexp "(" "PARAMS ((" nil)
(beginning-of-buffer)
(replace-regexp " ?[a-z_]*," "," nil)
(beginning-of-buffer)
)
Andreas
2001-08-25 Andreas Jaeger <aj@suse.de>
* oasys.c: Add missing prototypes.
* elf64-alpha.c (elf64_alpha_size_dynamic_sections): Add unused
attribute for parameter.
* elf.c (_bfd_elf_reloc_type_class): Likewise.
* versados.c (get_4): Make static.
(get_10): Make static.
Add missing prototypes.
(process_esd): Fix call to versados_new_symbol.
(process_esd): Likewise.
============================================================
Index: bfd/elf64-alpha.c
--- bfd/elf64-alpha.c 2001/08/24 11:17:29 1.31
+++ bfd/elf64-alpha.c 2001/08/25 16:11:35
@@ -3219,7 +3219,7 @@
static boolean
elf64_alpha_size_dynamic_sections (output_bfd, info)
- bfd *output_bfd;
+ bfd *output_bfd ATTRIBUTE_UNUSED;
struct bfd_link_info *info;
{
bfd *dynobj;
============================================================
Index: bfd/elf.c
--- bfd/elf.c 2001/08/24 20:10:25 1.86
+++ bfd/elf.c 2001/08/25 16:11:42
@@ -6063,7 +6063,7 @@
enum elf_reloc_type_class
_bfd_elf_reloc_type_class (type)
- int type;
+ int type ATTRIBUTE_UNUSED;
{
return reloc_class_normal;
}
============================================================
Index: bfd/versados.c
--- bfd/versados.c 2001/08/23 15:45:19 1.8
+++ bfd/versados.c 2001/08/25 16:11:43
@@ -1,5 +1,5 @@
/* BFD back-end for VERSAdos-E objects.
- Copyright 1995, 1996, 1998, 1999, 2000 Free Software Foundation, Inc.
+ Copyright 1995, 1996, 1998, 1999, 2000, 2001 Free Software Foundation, Inc.
Written by Steve Chamberlain of Cygnus Support <sac@cygnus.com>.
Versados is a Motorola trademark.
@@ -46,6 +46,18 @@
static boolean versados_mkobject PARAMS ((bfd *));
static boolean versados_scan PARAMS ((bfd *));
static const bfd_target *versados_object_p PARAMS ((bfd *));
+static asymbol *versados_new_symbol PARAMS ((bfd *, int, const char *, bfd_vma, asection *));
+static char *new_symbol_string PARAMS ((bfd *, char *));
+static const bfd_target *versados_object_p PARAMS ((bfd *));
+static boolean versados_pass_2 PARAMS ((bfd *));
+static boolean versados_get_section_contents
+ PARAMS ((bfd *, asection *, void *, file_ptr, bfd_size_type));
+static boolean versados_set_section_contents
+ PARAMS ((bfd *, sec_ptr, void *, file_ptr, bfd_size_type));
+static int versados_sizeof_headers PARAMS ((bfd *, boolean));
+static asymbol *versados_make_empty_symbol PARAMS ((bfd *));
+static long int versados_get_symtab_upper_bound PARAMS ((bfd *));
+static long int versados_get_symtab PARAMS ((bfd *, asymbol **));
#define VHEADER '1'
#define VESTDEF '2'
@@ -141,6 +153,13 @@
struct ext_otr otr;
};
+static int get_record PARAMS ((bfd *, union ext_any *));
+static int get_4 PARAMS ((unsigned char **));
+static void get_10 PARAMS ((unsigned char **, char *));
+static void process_esd PARAMS ((bfd *, struct ext_esd *, int));
+static int get_offset PARAMS ((int, unsigned char *));
+static void process_otr PARAMS ((bfd *, struct ext_otr *, int));
+
/* Initialize by filling in the hex conversion array. */
/* Set up the tdata information. */
@@ -195,7 +214,7 @@
return 1;
}
-int
+static int
get_4 (pp)
unsigned char **pp;
{
@@ -204,7 +223,7 @@
return (p[0] << 24) | (p[1] << 16) | (p[2] << 8) | (p[3] << 0);
}
-void
+static void
get_10 (pp, name)
unsigned char **pp;
char *name;
@@ -276,7 +295,7 @@
asymbol *s;
char *n = new_symbol_string (abfd, name);
s = versados_new_symbol (abfd, snum, n, 0,
- &bfd_und_section, scn);
+ &bfd_und_section);
esidx = VDATA (abfd)->es_done++;
RDATA (abfd, esidx - ES_BASE) = s;
}
@@ -311,7 +330,7 @@
{
asymbol *s;
char *n = new_symbol_string (abfd, name);
- s = versados_new_symbol (abfd, snum + VDATA (abfd)->nrefs, n, val, sec, scn);
+ s = versados_new_symbol (abfd, snum + VDATA (abfd)->nrefs, n, val, sec);
s->flags |= BSF_GLOBAL;
}
}
============================================================
Index: bfd/oasys.c
--- bfd/oasys.c 2001/08/23 15:45:19 1.9
+++ bfd/oasys.c 2001/08/25 16:11:44
@@ -1,5 +1,5 @@
/* BFD back-end for oasys objects.
- Copyright 1990, 1991, 1992, 1993, 1994, 1995, 1996, 1998, 1999
+ Copyright 1990, 1991, 1992, 1993, 1994, 1995, 1996, 1998, 1999, 2001
Free Software Foundation, Inc.
Written by Steve Chamberlain of Cygnus Support, <sac@cygnus.com>.
@@ -38,6 +38,28 @@
static boolean oasys_write_header PARAMS ((bfd *));
static boolean oasys_write_end PARAMS ((bfd *));
static boolean oasys_write_data PARAMS ((bfd *));
+static size_t oasys_string_length PARAMS ((oasys_record_union_type *));
+static boolean oasys_slurp_symbol_table PARAMS ((bfd *const));
+static long int oasys_get_symtab_upper_bound PARAMS ((bfd *const));
+static const bfd_target *oasys_archive_p PARAMS ((bfd *));
+static boolean oasys_mkobject PARAMS ((bfd *));
+static const bfd_target *oasys_object_p PARAMS ((bfd *));
+static void oasys_get_symbol_info PARAMS ((bfd *, asymbol *, symbol_info *));
+static void oasys_print_symbol PARAMS ((bfd *, void *, asymbol *, bfd_print_symbol_type));
+static boolean oasys_new_section_hook PARAMS ((bfd *, asection *));
+static long int oasys_get_reloc_upper_bound PARAMS ((bfd *, sec_ptr));
+static boolean oasys_get_section_contents
+ PARAMS ((bfd *, sec_ptr, void *, file_ptr, bfd_size_type));
+static int comp PARAMS ((const void *, const void *));
+static boolean oasys_write_object_contents PARAMS ((bfd *));
+static boolean oasys_set_section_contents
+ PARAMS ((bfd *, sec_ptr, void *, file_ptr, bfd_size_type));
+static asymbol *oasys_make_empty_symbol PARAMS ((bfd *));
+static bfd *oasys_openr_next_archived_file PARAMS ((bfd *, bfd *));
+static boolean oasys_find_nearest_line
+ PARAMS ((bfd *, asection *, asymbol **, bfd_vma, char **, char **, unsigned int *));
+static int oasys_generic_stat_arch_elt PARAMS ((bfd *, struct stat *));
+static int oasys_sizeof_headers PARAMS ((bfd *, boolean));
/* Read in all the section data and relocation stuff too */
PROTO (static boolean, oasys_slurp_section_data, (bfd * CONST abfd));
--
Andreas Jaeger
SuSE Labs aj@suse.de
private aj@arthur.inka.de
http://www.suse.de/~aj