Re: [PATCH] Fix check for 64bit support in MIPS gas

[Eric Christopher <echristo at redhat dot com>]

Ok.

-eric

On 16 Aug 2001 21:58:36 +0200, Thiemo Seufer wrote:
> H . J . Lu wrote:
> [snip]
> > > I added an check
> > >     strcmp (*l, "elf64-tradlittlemips") == 0)
> > > for the arch string in the option parsing code for "-64" which was
> > > obviously forgotten there.
> > 
> > Here is what I have
> > 
> >     case OPTION_64:
> >       {
> >         const char **list, **l;
> > 
> >         list = bfd_target_list ();
> >         for (l = list; *l != NULL; l++)
> >           if (strcmp (*l, "elf64-bigmips") == 0
> >               || strcmp (*l, "elf64-littlemips") == 0
> >               || strcmp (*l, "elf64-tradbigmips") == 0
> >               || strcmp (*l, "elf64-tradlittlemips") == 0)
> >             break;
> >         if (*l == NULL)
> >           as_fatal (_("No compiled in support for 64 bit object file format"));
> >         free (list);
> >         mips_64 = 1; 
> >       }
> >       break;  
> > 
> > There is
> > 
> > || strcmp (*l, "elf64-tradlittlemips") == 0)
> > 
> > Did I miss something?
> 
> No, you are right, sorry for the confusion. Obviously I can't read
> my own patches when I'm tired. Version with fixed ChangeLog is below.
> 
> 
> Thiemo
> 
> 
> 2001-08-16  Thiemo Seufer <seufer@csv.ica.uni-stuttgart.de>
> 
> 	/gas/ChangeLog
> 	* config/tc-mips.c (md_parse_option): #ifdef the
> 	traditional/non-traditional names as it is done in mips_target_format.
> 
> 
> diff -BurpNX /bigdisk/src/binutils-exclude src-orig/gas/config/tc-mips.c src/gas/config/tc-mips.c
> --- src-orig/gas/config/tc-mips.c	Sun Aug 12 13:34:58 2001
> +++ src/gas/config/tc-mips.c	Thu Aug 16 02:23:17 2001
> @@ -9129,10 +9430,14 @@ md_parse_option (c, arg)
>  
>  	list = bfd_target_list ();
>  	for (l = list; *l != NULL; l++)
> -	  if (strcmp (*l, "elf64-bigmips") == 0
> -	      || strcmp (*l, "elf64-littlemips") == 0
> -	      || strcmp (*l, "elf64-tradbigmips") == 0
> +#ifdef TE_TMIPS
> +	  /* This is traditional mips */
> +	  if (strcmp (*l, "elf64-tradbigmips") == 0
>  	      || strcmp (*l, "elf64-tradlittlemips") == 0)
> +#else
> +	  if (strcmp (*l, "elf64-bigmips") == 0
> +	      || strcmp (*l, "elf64-littlemips") == 0)
> +#endif
>  	    break;
>  	if (*l == NULL)
>  	  as_fatal (_("No compiled in support for 64 bit object file format"));
-- 
Look out behind you!