This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [patch] windres



> Is this the information that you needed to submit a patch to the
> configure script to allow --with-windres?  I had seen someone on the
> list suggest that windres would be build if you did a 'configure
> --with-all', but that doesn't cause windres to be built..

Applied.  Thanks!

> Let me know what else you need, I am not familiar with the process of
> submitting patches.

Just some minor points:

* Please submit patches as inline text so they can be read without
  having to decode them.

* ChangeLog entries should be proper sentences (capitalization)

* Blank line between name and entry in ChangeLogs; use hard tab to
  indent.

* The ChangeLog entry is normally supplied as regular text, not as a
  patch, because they usually don't apply cleanly (yours didn't
  because someone else had checked in a patch before I got yours in).

* You need an entry for configure, even if it only says "Likewise." or
  "Regenerated.".


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]