This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: PATCH: Check EI_OSABI for ELF/HPPA.


On Sat, Jun 02, 2001 at 11:15:19AM -0700, H . J . Lu wrote:
> 	* elf32-hppa.c (elf32_hppa_object_p): Check ELFOSABI_LINUX
> 	and ELFOSABI_HPUX.

OK.

> 	* elf64-hppa.c (elf64_hppa_object_p): Check ELFOSABI_LINUX
> 	and ELFOSABI_HPUX/EI_ABIVERSION.

OK, but it may be better to leave out the ABIVERSION check.  The
OSABI byte is sufficient to distinguish the two varieties.

Thanks for fixing this.  I've been aware of the problem for some time
but never got annoyed enough to fix it, as it only affects cross-tools
and can be worked around by giving the target explicitly on the
command line.

-- 
Alan Modra


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]