This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Bug in operands to IA32 cvtps2dq instruction in gnu as


On Sun, May 13, 2001 at 12:23:09AM +0930, amodra@one.net.au wrote:
> On Sat, May 12, 2001 at 07:41:56AM -0700, H . J . Lu wrote:
> > I am not sure about making it file scope. Is that really what we
> > want?
> 
> "file scope" just means the variable is visible anywhere in the
> file.
> 
> > I thought it was set by the current insn and you had to check
> > it for each insn.
> 
> It is still used in the same way.

I don't like to take any chances. I checked in this patch.


H.J.
-----
2001-05-12  H.J. Lu  <hjl@gnu.org>

	* i386-dis.c (print_insn_i386): Always set `mod', `reg' and
	`rm'.

Index: i386-dis.c
===================================================================
RCS file: /work/cvs/gnu/binutils/opcodes/i386-dis.c,v
retrieving revision 1.1.1.18
diff -u -p -r1.1.1.18 i386-dis.c
--- i386-dis.c	2001/05/12 15:01:18	1.1.1.18
+++ i386-dis.c	2001/05/12 15:16:02
@@ -3146,6 +3146,12 @@ print_insn_i386 (pc, info)
       reg = (*codep >> 3) & 7;
       rm = *codep & 7;
     }
+  else
+    {
+      mod = 0;
+      reg = 0;
+      rm = 0;
+    }
 
   if (dp->name == NULL && dp->bytemode1 == FLOATCODE)
     {


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]