This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH] More mostly cosmetic changes all over binutils
- To: Thiemo Seufer <ica2_ts at csv dot ica dot uni-stuttgart dot de>
- Subject: Re: [PATCH] More mostly cosmetic changes all over binutils
- From: Alan Modra <alan at SPRI dot Levels dot UniSA dot Edu dot Au>
- Date: Mon, 7 May 2001 18:56:25 +0930 (CST)
- cc: <binutils at sources dot redhat dot com>
On Fri, 4 May 2001, Thiemo Seufer wrote:
> 2001-05-03 Thiemo Seufer <seufer@csv.ica.uni-stuttgart.de>
>
> /bfd/ChangeLog
> * ecoff.c (bfd_debug_section): Fix initialization.
> * elf.c (_bfd_elf_slurp_version_tables): Change maxidx to unsigned, it
> is always a positive integer. Cast away sign mismatch.
> * elf32-mips.c: Fix misleading comment and typo.
> (_bfd_mips_elf_section_from_bfd_section): Remove unused attribute, use
> correct data type.
> * elflink.c: Fix typo.
> (_bfd_elf_create_dynamic_sections): Remove superfluous initialization.
> * ecoffswap.h (ecoff_swap_fdr_in): Cast away sign mismatch.
Applied.
> 2001-05-03 Thiemo Seufer <seufer@csv.ica.uni-stuttgart.de>
>
> /binutils/ChangeLog
> * readelf.c (process_unwind): Remove const specifier.
Applied.
> 2001-05-03 Thiemo Seufer <seufer@csv.ica.uni-stuttgart.de>
>
> /include/elf/ChangeLog
> * external.h: Fix typo.
> * mips.h: Add/Extend many comments with reference to the MIPS ELF64
> spec v. 2.4, available at e.g.
> ftp://oss.sgi.com/pub/linux/mips/doc/ABI/ELF64.ps.
> (EF_MIPS_UCODE): Define.
> (EF_MIPS_OPTIONS_FIRST): Define.
> (EF_MIPS_ARCH_ASE): Define.
> (EF_MIPS_ARCH_ASE_MDMX): Define.
> (EF_MIPS_ARCH_ASE_M16): Define.
> (SHF_MIPS_ADDR): Renamed SHF_MIPS_ADDR32.
> (SHF_MIPS_STRING): Renamed SHF_MIPS_ADDR64.
> (SHF_MIPS_NODUPES): Define.
> (ELF64_MIPS_R_SSYM): New MIPS ELF 64 relocation info access macro.
> (ELF64_MIPS_R_TYPE3): Likewise.
> (ELF64_MIPS_R_TYPE2): Likewise.
> (ELF64_MIPS_R_TYPE): Likewise.
> (OHW_R10KLDL): Define.
Applied.
> 2001-05-03 Thiemo Seufer <seufer@csv.ica.uni-stuttgart.de>
>
> /ld/ChangeLog
> * ldgram.y: Fix typo.
Applied.
> 2001-05-03 Thiemo Seufer <seufer@csv.ica.uni-stuttgart.de>
>
> /libiberty/ChangeLog
> * md5.c (md5_init_ctx): Declare constants as unsigned.
> (md5_process_block): Likewise.
Not applied.
a) libiberty patches should go to DJ Delorie <dj@redhat.com>.
b) Casting to unsigned is wrong if unsigned ints are 16 bits. I suppose a
cast to md5_uint32 would be OK.
Sorry for not catching this in the last review. (b) isn't such a problem
in binutils as >= 32 bit ints are assumed all over the place.
> 2001-05-03 Thiemo Seufer <seufer@csv.ica.uni-stuttgart.de>
>
> /opcodes/ChangeLog
> * disassemble.c (disassembler_usage): Remove unused attribute.
Applied.