This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: elflink.h -Bsymbolic change
- To: alan at linuxcare dot com dot au
- Subject: Re: elflink.h -Bsymbolic change
- From: Hans-Peter Nilsson <hans-peter dot nilsson at axis dot com>
- Date: Mon, 9 Apr 2001 04:21:35 +0200
- CC: binutils at sourceware dot cygnus dot com
> Date: Mon, 9 Apr 2001 11:31:35 +1000 (EST)
> From: Alan Modra <alan@linuxcare.com.au>
[Drepper:]
> > The patch Hans-Peter
> > proposed seems to be correct so in fact it is already fixed once he
> > gets the OK to apply it.
>
> Actually, I don't think it is correct. Certainly, I shouldn't have forced
> the protected symbols local, but on the other hand they do need to lose
> their .plt entry, don't they? Otherwise they won't be "protected" from
> the dynamic linker binding against some other symbol. See attached patch
> for another fix, which moves the symbol hiding out of
> elf_backend_hide_symbol back into elflink.h
FWIW, this patch looks good to me. (Or "better", I should say. :-)
brgds, H-P