This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: IPA changes to ld
- To: Jim Kingdon <jkingdon at engr dot sgi dot com>
- Subject: Re: IPA changes to ld
- From: Nick Clifton <nickc at redhat dot com>
- Date: 23 Feb 2001 12:52:44 -0800
- Cc: binutils at sources dot redhat dot com
- References: <200102230502.AAA08922@panix3.panix.com>
Hi Jim,
Thanks very much for submitting this patch. I would be amenable to
accepting it, if you are prepared to make some changes:
As has already been mentioned there is a problem with the formatting
of the code in the patch, and for a change as big as this, it would
be good to keep to the GNU coding guidelines.
There is also the fact that the code is written for ISO-C only and
could not be compiled with a K&R compiler. (You would have Michael
Sokolov breathing down your throat if the patch was applied, as
is). Also the code uses #pragma weak, which really ought to be a
#define'd macro to either do nothing (for compilers that do not
support weak symbols), or use __attribute__((weak)) for gcc, or use
#pragma weak for the SGI compiler.
Your patch involves changes to bfd-in2.h, but this is an
automatically generated file, and the patch did not include the
matching changes to the source files (bfd/section.c in this case).
Similarly you include changes to the auto-generated configure files
but not the corresponding configure.in files.
You appear to have some new bfd source files but no patch to
bfd/Makefile.am to include them in a build of the bfd library.
The file bfd/ipa_cmdline.c appears to define its own versions of the
ELF structures, rather than using the ones defined in
include/elf/{internal|external}.h.
One other thing that I would ask is if you, or someone else at SGI
would volunteer to be the official maintainer for this code, so that
it does not just bit-rot into obscurity.
Cheers
Nick