This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [patches] Re: Patch: x86_64 disassembler support


> Why the above changes when you have a new table for x86_64?  Seems to me
> like an unnecessary change, perhaps from when you were attempting to
> implement without a separate table?
Well, the changes are just to keep both tables in sync - it is then easier
to find bugs by diffing the tables.
Thats why I've kept the changes, that makes no functional difference even
in the old table.

If you preffer not modyfing the table, I can just erase these changes.
> > !   x = *codep++ & (bfd_signed_vma)0xff;
> space after `)'  Check other places in patch too.  
Oops, I tought that for retyping the space is not required.
OK I see it is used in other code.

Honza

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]