This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: PATCH: gas/config/tc-hppa.c: CHECK_FIELD typos.


On Wed, 13 Dec 2000 RDBrown@mira.net wrote:

> There is another candidate in pa_ip, but excluding zero seems possible.
> 
>             /* Handle a 9 bit immediate at 28.  */
>             case '$':
>               num = pa_get_absolute_expression (&the_insn, &s);
>               if (strict && the_insn.exp.X_op != O_constant)
>                 break;
>               s = expr_end;
>               CHECK_FIELD (num, 511, 1, strict);
>               INSERT_FIELD_AND_CONTINUE (opcode, num, 3);

I think it's fair enough to leave this one as is.  "popbts 0" ought to be
a nop, but I doubt anyone would ever want to use it.  It's far more likely
to be a typo.

> 2000-12-13  Rodney Brown  <RodneyBrown@mynd.com>
> 
> 	* config/tc-hppa.c (pa_ip): Correct CHECK_FIELD typo.
> 	(md_apply_fix): Correct possible CHECK_FIELD typo.

Thanks, applied.

-- 
Linuxcare.  Support for the Revolution.



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]