This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [patch] make gas ELF tests expect to fail on most mips*-*


On 18 Oct 2000, Chris G. Demetriou wrote:
> Eric Christopher <echristo@cygnus.com> writes:
> > Not being one of the maintainerly folks all I can do is comment, but I'd
> > rather see the tests fixed than to simply disable them.  If the output
> > is correct but xfailed we won't know when it is actually broken.
> 
> I agree, in general.  However, in this case, I didn't because it also
> potentially effects the checks made on lots of other ELF targets.

Well, since the purpose of these tests is to check that .pushsection,
.popsection and .previous work, it probably wouldn't hurt to pad the data
out.  I've committed the following.

	* gas/elf/section0.s: Ensure section sizes are multiples of 16.
	* gas/elf/section1.s: Likewise.
	* gas/elf/section[01].d: Change to suit.

-- 
Linuxcare.  Support for the Revolution.
Index: gas/elf/section0.d
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/elf/section0.d,v
retrieving revision 1.2
diff -u -p -r1.2 section0.d
--- section0.d	1999/10/11 03:40:17	1.2
+++ section0.d	2000/10/19 03:11:46
@@ -5,12 +5,12 @@
 
 Contents of section .text:
 Contents of section .data:
- 0000 0000                                 ..              
+ 0+000 00 ?00 ?00 ?00 ?00 ?00 ?00 ?00 ?00 ?00 ?00 ?00 ?00 ?00 ?00 ?00.*
 # The MIPS includes a 'section .reginfo' and such here.
 #...
 Contents of section A:
- 0000 010101                               ...             
+ 0+000 01 ?01 ?01 ?01 ?01 ?01 ?01 ?01 ?01 ?01 ?01 ?01 ?01 ?01 ?01 ?01.*
 Contents of section B:
- 0000 0202                                 ..              
+ 0+000 02 ?02 ?02 ?02 ?02 ?02 ?02 ?02 ?02 ?02 ?02 ?02 ?02 ?02 ?02 ?02.*
 Contents of section C:
- 0000 03                                   .               
+ 0+000 03 ?03 ?03 ?03 ?03 ?03 ?03 ?03 ?03 ?03 ?03 ?03 ?03 ?03 ?03 ?03.*
Index: gas/elf/section0.s
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/elf/section0.s,v
retrieving revision 1.2
diff -u -p -r1.2 section0.s
--- section0.s	2000/05/01 23:56:49	1.2
+++ section0.s	2000/10/19 03:11:46
@@ -1,11 +1,11 @@
  .data
-	.byte 0
+	.byte 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0
  .section A
-	.byte 1
+	.byte 1,1,1,1,1,1,1,1,1,1,1,1,1,1
  .pushsection B
-	.byte 2
+	.byte 2,2,2,2,2,2,2,2,2,2,2,2,2,2,2
  .pushsection C
-	.byte 3
+	.byte 3,3,3,3,3,3,3,3,3,3,3,3,3,3,3,3
  .popsection
 	.byte 2
  .popsection
Index: gas/elf/section1.d
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/elf/section1.d,v
retrieving revision 1.2
diff -u -p -r1.2 section1.d
--- section1.d	1999/10/11 03:40:17	1.2
+++ section1.d	2000/10/19 03:11:46
@@ -5,12 +5,12 @@
 
 Contents of section .text:
 Contents of section .data:
- 0000 000000                               ...             
+ 0+000 00 ?00 ?00 ?00 ?00 ?00 ?00 ?00 ?00 ?00 ?00 ?00 ?00 ?00 ?00 ?00.*
 # The MIPS includes a 'section .reginfo' and such here.
 #...
 Contents of section A:
- 0000 01010101 0101                        ......          
+ 0+000 01 ?01 ?01 ?01 ?01 ?01 ?01 ?01 ?01 ?01 ?01 ?01 ?01 ?01 ?01 ?01.*
 Contents of section B:
- 0000 02020202 02                          .....           
+ 0+000 02 ?02 ?02 ?02 ?02 ?02 ?02 ?02 ?02 ?02 ?02 ?02 ?02 ?02 ?02 ?02.*
 Contents of section C:
- 0000 0303                                 ..              
+ 0+000 03 ?03 ?03 ?03 ?03 ?03 ?03 ?03 ?03 ?03 ?03 ?03 ?03 ?03 ?03 ?03.*
Index: gas/elf/section1.s
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/elf/section1.s,v
retrieving revision 1.2
diff -u -p -r1.2 section1.s
--- section1.s	2000/05/01 23:56:49	1.2
+++ section1.s	2000/10/19 03:11:46
@@ -1,19 +1,19 @@
  .data
-	.byte 0
+	.byte 0,0,0,0,0,0,0,0,0,0,0,0,0,0
  .section A
-	.byte 1
+	.byte 1,1,1,1,1,1,1,1,1,1,1
  .previous
 	.byte 0
  .previous
 	.byte 1
  .pushsection B
-	.byte 2
+	.byte 2,2,2,2,2,2,2,2,2,2,2,2
  .previous
 	.byte 1
  .previous
 	.byte 2
  .pushsection C
-	.byte 3
+	.byte 3,3,3,3,3,3,3,3,3,3,3,3,3,3,3
  .previous
 	.byte 2
  .previous


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]