This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [patch] MIPS32 is a real ISA, and MIPS ISA/CPU name/constant cleanup.
Chris G. Demetriou writes:
> Here's part one of the revision. it contains only the ISA number ->
> constant, ISA/CPU name table cleanup, and MIPS32-related changes.
I have a style nit.
The GNU coding standards say to not put a blank line
between associated ChangeLog entries.
Separate unrelated change log entries with blank lines. When two
entries represent parts of the same change, so that they work together,
then don't put blank lines between them. Then you can omit the file
name and the asterisk when successive entries are in the same file.
When I'm scanning changelogs it's nice to be able to trivially
see what group of changes are related. That's what the blank
line is for.
> for bfd/ChangeLog:
>
> 2000-10-13 Chris Demetriou <cgd@sibyte.com>
>
> * aoutx.h (NAME(aout,machine_type)): Add
> bfd_mach_mips32_generic to the machine list, and clean up
> comment.
>
> * archures.c (bfd_mach_mips4K, bfd_mach_mips32_generic):
> Replace the former with the latter.
>
> * bfd-in2.h (bfd_mach_mips4K, bfd_mach_mips32_generic):
> Likewise.
>
> * cpu-mips.c (I_mips4K, I_mips32_generic): Likewise.
> (arch_info_struct): Update comment, replace mips:4K entry
> with mips:generic-mips32 entry.
>
> * elf32-mips.c (elf_mips_isa): Add E_MIPS_ARCH_32 case.
> (elf_mips_mach): Likewise. Also, replace E_MIPS_MACH_MIPS32
> with E_MIPS_MACH_MIPS32_GENERIC.
> (_bfd_mips_elf_final_write_processing): Replace bfd_mach_mips4K
> with bfd_mach_mips32_generic.
> (_bfd_mips_elf_merge_private_bfd_data): Generalize ISA mixing
> comparison with support for MIPS32.
> (_bfd_mips_elf_print_private_bfd_data): Print ISA name for
> MIPS32.