This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [patch] pe-dll.c: Fix formatting (another one!)
- To: binutils at sources dot redhat dot com
- Subject: Re: [patch] pe-dll.c: Fix formatting (another one!)
- From: Kazu Hirata <kazu at hxi dot com>
Hi,
> I'm not too keen on these types of reformatting. It makes it a lot
> harder to search for structure definitions, and interferes with
> searching for function definitions. Also, I couldn't find the
Sorry, this is completely my mistake. They are neither required by
the GNU coding style nor even suggested by indent. Attached patch
should fix them. OK to apply?
Thanks,
Kazu Hirata
===File ~/gnu/binutils/ChangeLog-pe-dll.c===================
2000-10-09 Kazu Hirata <kazu@hxi.com>
* pe-dll.c: Revert some formatting fixes.
============================================================
===File ~/gnu/binutils/pe-dll.c.patch=======================
Index: pe-dll.c
===================================================================
RCS file: /cvs/src/src/ld/pe-dll.c,v
retrieving revision 1.20
diff -u -r1.20 pe-dll.c
--- pe-dll.c 2000/10/09 07:01:29 1.20
+++ pe-dll.c 2000/10/09 14:55:39
@@ -84,8 +84,7 @@
int pe_arch;
int bfd_arch;
int underscored;
-}
-pe_details_type;
+} pe_details_type;
#define PE_ARCH_i386 1
#define PE_ARCH_sh 2
@@ -159,8 +158,7 @@
bfd_vma vma;
char type;
short extra;
-}
-reloc_data_type;
+} reloc_data_type;
static int
reloc_sort (va, vb)
@@ -204,8 +202,7 @@
typedef struct exclude_list_struct {
char *string;
struct exclude_list_struct *next;
-}
-exclude_list_struct;
+} exclude_list_struct;
static struct exclude_list_struct *excludes = 0;
@@ -848,6 +845,9 @@
free (relocs);
/* Warning: the allocated symbols are remembered in BFD and
reused later, so don't free them! */
+#if 0
+ free (symbol);
+#endif
}
}
============================================================