This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [patch] pe-dll.c: Fix formatting (another one!)


On Mon, 9 Oct 2000, Kazu Hirata wrote:

> --- pe-dll.c	2000/10/09 01:37:11	1.19
> +++ pe-dll.c	2000/10/09 03:02:29
> @@ -77,14 +77,16 @@
>  static unsigned char *edata_d, *reloc_d;
>  static size_t edata_sz, reloc_sz;
>  
> -typedef struct {
> +typedef struct
> +{

According to http://www.gnu.ai.mit.edu/prep/standards_22.html,
"It is important to put the open-brace that starts the body of a C
function in column zero, and avoid putting any other open-brace or
open-parenthesis or open-bracket in column zero."

Yes, I know there are many places in the binutils source that disobey this
rule, and you were trying to be consistent.  However, it's probably best
to reduce the number of places where binutils' source does not meet the
standard. ;-)

Alan Modra
-- 
Linuxcare.  Support for the Revolution.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]