This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [patch] binutils/resrc.c
- To: DJ Delorie <dj at delorie dot com>
- Subject: Re: [patch] binutils/resrc.c
- From: Jamie Guinan <guinan at bluebutton dot com>
- Date: Tue, 29 Aug 2000 21:51:16 -0400 (EDT)
- cc: binutils at sourceware dot cygnus dot com
- Reply-To: guinan at bluebutton dot com
Indeedd, I was working with 2.10 and even though I patched
against CVS I didn't notice the extra "cpp_pipe = NULL;"
had been added.
But I saw that cpp_pipe was [pf]close'd on either path of the
subsequent "if" statement, and set to NULL at the end, so it
still seems to me like the top "if" can go away.
-Jamie
On Tue, 29 Aug 2000, DJ Delorie wrote:
> You don't have the latest sources. In the latest sources (in CVS),
> the code looks like this:
>
> static void
> close_input_stream ()
> {
> if (cpp_pipe != NULL)
> {
> pclose (cpp_pipe);
> cpp_pipe = NULL;
> }