This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
A visibility patch for ELF/PPC
- To: binutils at sourceware dot cygnus dot com
- Subject: A visibility patch for ELF/PPC
- From: "H . J . Lu" <hjl at valinux dot com>
- Date: Sat, 19 Aug 2000 17:48:57 -0700
- Cc: loewis at informatik dot hu-berlin dot de
ELF/PPC needs this patch to pass "make check" in elf from glibc 2.1.92.
I don't know enough about ELF/PPC to be sure if it is 100% correct.
Any comments?
Thanks.
--
H.J. Lu (hjl@gnu.org)
---
2000-08-19 H.J. Lu <hjl@gnu.org>
* elf32-ppc.c (ppc_elf_relocate_section): Symbols with the non
default visibility in DSO need relocation.
Index: elf32-ppc.c
===================================================================
RCS file: /work/cvs/gnu/binutils/bfd/elf32-ppc.c,v
retrieving revision 1.8
diff -u -p -r1.8 elf32-ppc.c
--- elf32-ppc.c 2000/07/20 03:58:11 1.8
+++ elf32-ppc.c 2000/08/20 00:16:32
@@ -3024,7 +3024,9 @@ ppc_elf_relocate_section (output_bfd, in
|| (h->elf_link_hash_flags
& ELF_LINK_HASH_DEF_REGULAR) == 0))
|| (info->shared
- && ((! info->symbolic && h->dynindx != -1)
+ && ((! info->symbolic
+ && ELF_ST_VISIBILITY (h->other) == STV_DEFAULT
+ && h->dynindx != -1)
|| (h->elf_link_hash_flags
& ELF_LINK_HASH_DEF_REGULAR) == 0)
&& ((input_section->flags & SEC_ALLOC) != 0