This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

[patch] gas/configure.in: Use right string inequality operator and set right file


One bug cancelled the other for a recent change.  An invalid
operator was used for string compare, so te_file was never set
to the wrong value.  Setting te_file to multi would cause
te-multi.h to be referenced, but it does not exist anymore;
te-generic.h is the one to use (identical contents).

An alternative approach would be to delete the whole "if", since
it would never be executed; I'm not really sure why te_file is
set here at all.  Note also that te-tmips.h is effectively the
same as te-generic.h anyway.  A comment from Koundinya or Alan
would be helpful.

Or, Ok to commit?

2000-07-12  Hans-Peter Nilsson  <hp@axis.com>

	* configure.in (DEFAULT_EMULATION setting): Use operator != for
	string inequality test, not -ne.  Set te_file to generic, not
	multi.
	* configure: Regenerate.

Index: configure.in
===================================================================
RCS file: /cvs/src/src/gas/configure.in,v
retrieving revision 1.34
diff -p -c -r1.34 configure.in
*** configure.in	2000/07/09 08:16:21	1.34
--- configure.in	2000/07/12 15:22:33
*************** if test `set . $emfiles ; shift ; echo $
*** 736,744 ****
    case "${obj_format}${emfiles}" in
      multi* | *mips*)
    # if te_file is tmips, that means the target is mips-*-sysv4*MP* and we do
!   # not set it to multi.
!       if [[ $te_file -ne "tmips" ]]; then
!         te_file=multi
        fi
        extra_objects="$extra_objects $emfiles"
        AC_DEFINE(USE_EMULATIONS, 1, [Use emulation support?]) ;;
--- 741,749 ----
    case "${obj_format}${emfiles}" in
      multi* | *mips*)
    # if te_file is tmips, that means the target is mips-*-sysv4*MP* and we do
!   # not set it to generic.
!       if [[ $te_file != "tmips" ]]; then
!         te_file=generic
        fi
        extra_objects="$extra_objects $emfiles"
        AC_DEFINE(USE_EMULATIONS, 1, [Use emulation support?]) ;;

brgds, H-P

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]