This is the mail archive of the
binutils@sourceware.cygnus.com
mailing list for the binutils project.
Concern about recent patch
- To: binutils at sourceware dot cygnus dot com
- Subject: Concern about recent patch
- From: "Mark E." <snowball3 at bigfoot dot com>
- Date: Mon, 26 Jun 2000 16:36:53 -0400
Hi guys,
I'm very concerned about this change:
2000-06-25 Alexander Aganichev <AAganichev@hypercom.com>
* ar.c (normalize): Advance past both characters in a DOS based
<letter>: filepath prefix.
(main): Likewise.
* bucomm.c (make_tempname): Likewise.
I believe this patch should be reverted. For example, let variable 'file'
contain 'c:nm.o'.
if (filename == NULL && file[0] != '\0' && file[1] == ':')
filename = file + 2;
}
#endif
[filename now points to 'nm.o']
if (filename != (char *) NULL)
filename++;
else
[Oops! filename now points to 'm.o']
One solution is to revert the patch. But I'd also be in favor of replacing
this mess with basename and let it deal with the dirty work.
Mark