This is the mail archive of the
binutils@sourceware.cygnus.com
mailing list for the binutils project.
Re: (FWD) Re: patch to accept \t as a character by `strings'
- To: obrien at NUXI dot com
- Subject: Re: (FWD) Re: patch to accept \t as a character by `strings'
- From: Nick Clifton <nickc at cygnus dot com>
- Date: Mon, 22 May 2000 15:43:20 -0700
- CC: binutils at sourceware dot cygnus dot com
Hi David,
: ----- Forwarded message from David O'Brien <obrien@FreeBSD.org> -----
: |> Below is a patch so that `strings' output matches that of other systems.
: |> BSD since 1986/11/24 have defined <tab> to be a printable character (bug
: |> report 4.3BSD/ucb/9). HP-UX (since at least 10.20), Irix (since at least
: |> 5.3) also interprets <tab> this way.
:
: Is there any problems with committing this to HEAD and the 2.10 branch?
I assume that you mean the revised version ?
In which case the answer (for HEAD anyway) is: 'no problems, please
apply'.
Cheers
Nick
Index: strings.c
===================================================================
RCS file: /cvs/src/src/binutils/strings.c,v
retrieving revision 1.5
diff -u -r1.5 strings.c
--- strings.c 2000/04/07 04:34:50 1.5
+++ strings.c 2000/05/11 17:22:53
@@ -60,9 +60,9 @@
#include "libiberty.h"
#ifdef isascii
-#define isgraphic(c) (isascii (c) && isprint (c))
+#define isgraphic(c) (isascii (c) && (isprint (c) || (c) == '\t'))
#else
-#define isgraphic(c) (isprint (c))
+#define isgraphic(c) (isprint (c) || (c) == '\t')
#endif
#ifndef errno