This is the mail archive of the binutils@sourceware.cygnus.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Arrange for GAS testsuite's run_dump_test to not stop at first error


run_dump_test, from the gas testing framework, calls regexp_diff to
compare the output of objdump (or whatever) with the expected output.
However, it stops at the first difference found.  It would be much
more convenient to examine and fix bugs if it continued comparing the
files, reporting all differences it finds.

Admittedly, this may cause it to produce a lot useless log output
sometimes, but, whenever I care about the output log, I'd rather have
it all.  Ok to install?

Index: gas/testsuite/ChangeLog
from  Alexandre Oliva  <aoliva@cygnus.com>
	
	* lib/gas-defs.exp (regexp_diff): Don't break on the first
	difference, list them all.
	
Index: gas/testsuite/lib/gas-defs.exp
===================================================================
RCS file: /cvs/cvsfiles/devo/gas/testsuite/lib/gas-defs.exp,v
retrieving revision 1.43
diff -u -r1.43 gas-defs.exp
--- gas/testsuite/lib/gas-defs.exp	1999/10/11 04:38:12	1.43
+++ gas/testsuite/lib/gas-defs.exp	2000/03/31 14:57:25
@@ -1,4 +1,4 @@
-# Copyright (C) 1993, 1994, 1997 Free Software Foundation, Inc.
+# Copyright (C) 1993, 1994, 1997, 2000 Free Software Foundation, Inc.
 
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -535,7 +535,6 @@
 		send_log "regexp_diff match failure\n"
 		send_log "regexp \"^$line_b$\"\nline   \"$line_a\"\n"
 		set differences 1
-                break
             }
         }
     }

-- 
Alexandre Oliva    Enjoy Guaranį, see http://www.ic.unicamp.br/~oliva/
Cygnus Solutions, a Red Hat company        aoliva@{redhat, cygnus}.com
Free Software Developer and Evangelist    CS PhD student at IC-Unicamp
oliva@{lsd.ic.unicamp.br, gnu.org}   Write to mailing lists, not to me

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]