This is the mail archive of the
binutils@sourceware.cygnus.com
mailing list for the binutils project.
A patch for ELF_ST_OTHER.
- To: nickc at redhat dot com
- Subject: A patch for ELF_ST_OTHER.
- From: hjl at valinux dot com (H.J. Lu)
- Date: Mon, 21 Feb 2000 22:46:58 -0800
- Cc: binutils at sourceware dot cygnus dot com,Ulrich Drepper <drepper at cygnus dot com>
Hi, Nick,
ELF_ST_OTHER is removed from gABI. ELF_ST_OTHER was meant to work
like ELF_ST_INFO. But it doesn't make much sense here since we
only have ELF_ST_VISIBILITY in st_other. We voted to remove it
from gABI for the time being. Feel free to remove it altogether.
Thanks.
H.J.
--
Mon Feb 21 22:39:12 2000 H.J. Lu <hjl@gnu.org>
* common.h (ELF_ST_OTHER_REST): Renamed from ELF_ST_OTHER.
(ELF32_ST_OTHER_REST): Renamed from ELF32_ST_OTHER.
(ELF64_ST_OTHER_REST): ELF64_ST_OTHER.
Index: ./include/elf/common.h
===================================================================
RCS file: /work/cvs/gnu/binutils/include/elf/common.h,v
retrieving revision 1.9
diff -u -p -r1.9 common.h
--- ./include/elf/common.h 2000/01/21 21:08:27 1.9
+++ ./include/elf/common.h 2000/02/22 06:37:14
@@ -319,12 +319,12 @@ Foundation, Inc., 59 Temple Place - Suit
the st_other field. The STV_ defines specificy the actual visibility. */
#define ELF_ST_VISIBILITY(v) ((v) & 0x3)
-#define ELF_ST_OTHER(o) ((o) & ~0x3)
+#define ELF_ST_OTHER_REST(o) ((o) & ~0x3)
#define ELF32_ST_VISIBILITY ELF_ST_VISIBILITY
-#define ELF32_ST_OTHER ELF_ST_OTHER
+#define ELF32_ST_OTHER_REST ELF_ST_OTHER_REST
#define ELF64_ST_VISIBILITY ELF_ST_VISIBILITY
-#define ELF64_ST_OTHER ELF_ST_OTHER
+#define ELF64_ST_OTHER_REST ELF_ST_OTHER_REST
#define STN_UNDEF 0 /* undefined symbol index */
Mon Feb 21 22:41:30 1999 H.J. Lu (hjl@gnu.org)
* binutils/readelf.c (process_symbol_table): Use
ELF_ST_OTHER_REST instead ELF_ST_OTHER.
Index: ./binutils/readelf.c
===================================================================
RCS file: /work/cvs/gnu/binutils/binutils/readelf.c,v
retrieving revision 1.19
diff -u -p -r1.19 readelf.c
--- ./binutils/readelf.c 2000/01/28 17:10:50 1.19
+++ ./binutils/readelf.c 2000/02/22 06:37:30
@@ -4206,7 +4206,7 @@ process_symbol_table (file)
printf (" %6s", get_symbol_type (ELF_ST_TYPE (psym->st_info)));
printf (" %6s", get_symbol_binding (ELF_ST_BIND (psym->st_info)));
printf (" %3s", get_symbol_visibility (ELF_ST_VISIBILITY (psym->st_other)));
- printf (" %2d", ELF_ST_OTHER (psym->st_other));
+ printf (" %2d", ELF_ST_OTHER_REST (psym->st_other));
printf (" %3.3s", get_symbol_index_type (psym->st_shndx));
printf (" %s\n", dynamic_strings + psym->st_name);
}
@@ -4266,7 +4266,7 @@ process_symbol_table (file)
printf (" %-7s", get_symbol_type (ELF_ST_TYPE (psym->st_info)));
printf (" %-6s", get_symbol_binding (ELF_ST_BIND (psym->st_info)));
printf (" %-3s", get_symbol_visibility (ELF_ST_VISIBILITY (psym->st_other)));
- printf (" %2d", ELF_ST_OTHER (psym->st_other));
+ printf (" %2d", ELF_ST_OTHER_REST (psym->st_other));
printf (" %4s", get_symbol_index_type (psym->st_shndx));
printf (" %s", strtab + psym->st_name);