This is the mail archive of the
binutils@sourceware.cygnus.com
mailing list for the binutils project.
Re: PATCH: fix pa disassembly bug
- To: "Jerry Quinn" <jquinn@nortelnetworks.com>
- Subject: Re: PATCH: fix pa disassembly bug
- From: Jeffrey A Law <law@cygnus.com>
- Date: Wed, 28 Jul 1999 02:07:01 -0600
- cc: binutils@sourceware.cygnus.com
- Reply-To: law@cygnus.com
In message <199906210350.XAA26342@wmtl249c.us.nortel.com>you write:
> This patch fixes a bug with disassembly of xmpyu, fmpyfadd, and
> fmpynfadd. They were using the 'E' and 'X' codes to represent their
> two input operands. While the correct opcode is generated by gas, the
> disassembler would incorrectly read the opcode, using the wrong bit
> for l/r selection. The solution is to use 'J' and 'K' codes instead.
>
> Changelog:
>
> * gas/config/tc-hppa.c (pa_ip): Add 'J' and 'K' code
> processing.
> * include/opcode/hppa.h (pa_opcodes): Change xmpyu, fmpyfadd,
> and fmpynfadd to use 'J' and 'K' instead of 'E' and 'X'.
Thanks. Installed.
BTW, there is a disassembler testsuite in the gdb tree. It may be worth adding
a test for this problem.
jeff