[binutils-gdb] alpha testsuite fixes

Alan Modra amodra@sourceware.org
Tue Oct 23 10:39:00 GMT 2018


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=8e3152af14a91df65af8e922a0e8e77c60ed99ba

commit 8e3152af14a91df65af8e922a0e8e77c60ed99ba
Author: Alan Modra <amodra@gmail.com>
Date:   Tue Oct 23 15:50:43 2018 +1030

    alpha testsuite fixes
    
    Fixes a couple of ERROR results due to .set difference on alpha.
    
    	* testsuite/ld-elf/shared.exp: Don't build pr19073 test on alpha.
    	* testsuite/ld-elf/pr18720b.c: Don't use .set on alpha.

Diff:
---
 ld/ChangeLog                   |  5 +++++
 ld/testsuite/ld-elf/pr18720b.c |  4 ++++
 ld/testsuite/ld-elf/shared.exp | 19 +++++++++++++------
 3 files changed, 22 insertions(+), 6 deletions(-)

diff --git a/ld/ChangeLog b/ld/ChangeLog
index 6a029f8..f0a373d 100644
--- a/ld/ChangeLog
+++ b/ld/ChangeLog
@@ -1,3 +1,8 @@
+2018-10-23  Alan Modra  <amodra@gmail.com>
+
+	* testsuite/ld-elf/shared.exp: Don't build pr19073 test on alpha.
+	* testsuite/ld-elf/pr18720b.c: Don't use .set on alpha.
+
 2018-10-20  Alan Modra  <amodra@gmail.com>
 
 	* ldlang.c (lang_end): Don't error if no --entry or --undefined
diff --git a/ld/testsuite/ld-elf/pr18720b.c b/ld/testsuite/ld-elf/pr18720b.c
index 6a2975d..3644e5d 100644
--- a/ld/testsuite/ld-elf/pr18720b.c
+++ b/ld/testsuite/ld-elf/pr18720b.c
@@ -7,7 +7,11 @@ foo (void)
 }
 
 asm (".symver foo,foo@FOO");
+#ifdef __alpha__
+asm ("foo_alias = foo");
+#else
 asm (".set foo_alias,foo");
+#endif
 asm (".global foo_alias");
 #if defined __powerpc64__ && defined _CALL_AIXDESC && !defined _CALL_LINUX
 asm (".symver .foo,.foo@FOO");
diff --git a/ld/testsuite/ld-elf/shared.exp b/ld/testsuite/ld-elf/shared.exp
index c894d21..4c1b2ef 100644
--- a/ld/testsuite/ld-elf/shared.exp
+++ b/ld/testsuite/ld-elf/shared.exp
@@ -741,12 +741,19 @@ set build_tests {
   {"Build libpr18458b.so"
    "-shared -Wl,-z,now tmpdir/libpr18458a.so" "-fPIC"
    {pr18458b.c} {} "libpr18458b.so"}
-  {"Build pr19073a.o"
-   "-r -nostdlib" ""
-   {pr19073.s} {} "pr19073a.o"}
-  {"Build libpr19073.so"
-   "-shared -Wl,--version-script=pr19073.map tmpdir/pr19073a.o" "-fPIC"
-   {dummy.c} {{readelf {--dyn-syms --wide} pr19073.rd}} "libpr19073.so"}
+}
+# pr19073.s uses .set, which has a different meaning on alpha.
+if { ![istarget alpha-*-*] } {
+    append build_tests {
+	{"Build pr19073a.o"
+	 "-r -nostdlib" ""
+	 {pr19073.s} {} "pr19073a.o"}
+	{"Build libpr19073.so"
+	 "-shared -Wl,--version-script=pr19073.map tmpdir/pr19073a.o" "-fPIC"
+	 {dummy.c} {{readelf {--dyn-syms --wide} pr19073.rd}} "libpr19073.so"}
+    }
+}
+append build_tests {
   {"Build pr21964-1a.so"
    "-shared" "-fPIC"
    {pr21964-1a.c} {} "pr21964-1a.so"}



More information about the Binutils-cvs mailing list