This is the mail archive of the
binutils-cvs@sourceware.org
mailing list for the binutils project.
[binutils-gdb] Revert "_bfd_mips_elf_final_link: Notify user about wrong .reginfo size"
- From: Maciej W.Rozycki <macro at sourceware dot org>
- To: bfd-cvs at sourceware dot org
- Date: 19 Feb 2018 18:40:24 -0000
- Subject: [binutils-gdb] Revert "_bfd_mips_elf_final_link: Notify user about wrong .reginfo size"
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=b248d650a44fb49d59a548ad173a3e60646159da
commit b248d650a44fb49d59a548ad173a3e60646159da
Author: Maciej W. Rozycki <macro@mips.com>
Date: Mon Feb 19 18:38:41 2018 +0000
Revert "_bfd_mips_elf_final_link: Notify user about wrong .reginfo size"
Revert commit 58807c48a5a3 ("_bfd_mips_elf_final_link: Notify user about
wrong .reginfo size") now that the size of the `.reginfo' section has
been truly fixed in `_bfd_mips_elf_section_processing', meaning that the
offending condition can be asserted again.
bfd/
Revert
2018-01-12 Vlad Ivanov <vlad@ivanov.email>
* elfxx-mips.c (_bfd_mips_elf_final_link): Notify user when
.reginfo section has wrong size.
Diff:
---
bfd/ChangeLog | 8 ++++++++
bfd/elfxx-mips.c | 11 +----------
2 files changed, 9 insertions(+), 10 deletions(-)
diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 6820732..2ef145c 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,5 +1,13 @@
2018-02-19 Maciej W. Rozycki <macro@mips.com>
+ Revert
+ 2018-01-12 Vlad Ivanov <vlad@ivanov.email>
+
+ * elfxx-mips.c (_bfd_mips_elf_final_link): Notify user when
+ .reginfo section has wrong size.
+
+2018-02-19 Maciej W. Rozycki <macro@mips.com>
+
* elfxx-mips.c (_bfd_mips_elf_always_size_sections): Set
SEC_FIXED_SIZE and SEC_HAS_CONTENTS flags for `.reginfo' and
`.MIPS.abiflags' sections.
diff --git a/bfd/elfxx-mips.c b/bfd/elfxx-mips.c
index 1b24f66..e57d4cd 100644
--- a/bfd/elfxx-mips.c
+++ b/bfd/elfxx-mips.c
@@ -14412,16 +14412,7 @@ _bfd_mips_elf_final_link (bfd *abfd, struct bfd_link_info *info)
}
/* Size has been set in _bfd_mips_elf_always_size_sections. */
- if (o->size != sizeof (Elf32_External_RegInfo))
- {
- _bfd_error_handler
- (_("%pB: .reginfo section size should be %ld bytes, "
- "actual size is %" PRId64),
- abfd, (unsigned long) sizeof (Elf32_External_RegInfo),
- (int64_t) o->size);
-
- return FALSE;
- }
+ BFD_ASSERT(o->size == sizeof (Elf32_External_RegInfo));
/* Skip this section later on (I don't think this currently
matters, but someday it might). */