This is the mail archive of the mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[binutils-gdb] Add reference to implicit use in _bfd_elf_is_local_label_name.;h=0fbc35681ff0825be97802efcccf953bc4573a45

commit 0fbc35681ff0825be97802efcccf953bc4573a45
Author: Jim Wilson <>
Date:   Fri Nov 24 09:31:59 2017 -0800

    Add reference to implicit use in _bfd_elf_is_local_label_name.
    	* write.h (FAKE_LABEL_CHAR): Expand comment.

 gas/ChangeLog |  4 ++++
 gas/write.h   | 11 +++++++++--
 2 files changed, 13 insertions(+), 2 deletions(-)

diff --git a/gas/ChangeLog b/gas/ChangeLog
index d6c9d4c..13fee06 100644
--- a/gas/ChangeLog
+++ b/gas/ChangeLog
@@ -1,3 +1,7 @@
+2017-11-24  Jim Wilson  <>
+	* write.h (FAKE_LABEL_CHAR): Expand comment.
 2017-11-24  Jan Beulich  <>
 	* config/tc-i386.c (check_VecOperations): Check register type
diff --git a/gas/write.h b/gas/write.h
index 4157bc9..d2c6af6 100644
--- a/gas/write.h
+++ b/gas/write.h
@@ -27,8 +27,15 @@
 #define FAKE_LABEL_NAME "L0\001"
-/* This is the special character used to indicate a fake symbol.  Must be
-   present in FAKE_LABEL_NAME.  */
+/* This is a special character that is used to indicate a fake label.
+   It must be present in FAKE_LABEL_NAME, although it does not have to
+   be the first character.  It must not be a character that would be
+   found in a valid symbol name.
+   Also be aware that the function _bfd_elf_is_local_label_name in
+   bfd/elf.c has an implicit assumption that FAKE_LABEL_CHAR is '\001'.
+   If this is not the case then FAKE_LABEL_NAME must start with ".L" in
+   order for the function to continue working.  */
 #define FAKE_LABEL_CHAR '\001'

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]