This is the mail archive of the
binutils-cvs@sourceware.org
mailing list for the binutils project.
[binutils-gdb] Add reference to implicit use in _bfd_elf_is_local_label_name.
- From: Jim Wilson <wilson at sourceware dot org>
- To: bfd-cvs at sourceware dot org
- Date: 24 Nov 2017 17:32:40 -0000
- Subject: [binutils-gdb] Add reference to implicit use in _bfd_elf_is_local_label_name.
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=0fbc35681ff0825be97802efcccf953bc4573a45
commit 0fbc35681ff0825be97802efcccf953bc4573a45
Author: Jim Wilson <jimw@sifive.com>
Date: Fri Nov 24 09:31:59 2017 -0800
Add reference to implicit use in _bfd_elf_is_local_label_name.
gas/
* write.h (FAKE_LABEL_CHAR): Expand comment.
Diff:
---
gas/ChangeLog | 4 ++++
gas/write.h | 11 +++++++++--
2 files changed, 13 insertions(+), 2 deletions(-)
diff --git a/gas/ChangeLog b/gas/ChangeLog
index d6c9d4c..13fee06 100644
--- a/gas/ChangeLog
+++ b/gas/ChangeLog
@@ -1,3 +1,7 @@
+2017-11-24 Jim Wilson <jimw@sifive.com>
+
+ * write.h (FAKE_LABEL_CHAR): Expand comment.
+
2017-11-24 Jan Beulich <jbeulich@suse.com>
* config/tc-i386.c (check_VecOperations): Check register type
diff --git a/gas/write.h b/gas/write.h
index 4157bc9..d2c6af6 100644
--- a/gas/write.h
+++ b/gas/write.h
@@ -27,8 +27,15 @@
#define FAKE_LABEL_NAME "L0\001"
#endif
-/* This is the special character used to indicate a fake symbol. Must be
- present in FAKE_LABEL_NAME. */
+/* This is a special character that is used to indicate a fake label.
+ It must be present in FAKE_LABEL_NAME, although it does not have to
+ be the first character. It must not be a character that would be
+ found in a valid symbol name.
+
+ Also be aware that the function _bfd_elf_is_local_label_name in
+ bfd/elf.c has an implicit assumption that FAKE_LABEL_CHAR is '\001'.
+ If this is not the case then FAKE_LABEL_NAME must start with ".L" in
+ order for the function to continue working. */
#ifndef FAKE_LABEL_CHAR
#define FAKE_LABEL_CHAR '\001'
#endif