This is the mail archive of the
binutils-cvs@sourceware.org
mailing list for the binutils project.
[binutils-gdb] PR22263 testcase
- From: Alan Modra <amodra at sourceware dot org>
- To: bfd-cvs at sourceware dot org
- Date: 13 Oct 2017 13:46:12 -0000
- Subject: [binutils-gdb] PR22263 testcase
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=354bac403e9a19bbbfb676d854db5f11f0e84c27
commit 354bac403e9a19bbbfb676d854db5f11f0e84c27
Author: Alan Modra <amodra@gmail.com>
Date: Fri Oct 13 15:23:35 2017 +1030
PR22263 testcase
A number of targets need dynamic relocs in PIEs for reasons other than
relocating thread variables. The PR is about text relocations, and,
reading between the lines, unnecessary dynamic tprel relocations.
Change the test to check for those conditions rather than no dynamic
relocations
PR ld/22263
* testsuite/ld-elf/tls.exp: Link with -z text.
* testsuite/ld-elf/pr22263-1.rd: Test for tprel relocs.
Diff:
---
ld/ChangeLog | 6 ++++++
ld/testsuite/ld-elf/pr22263-1.rd | 7 +++++--
ld/testsuite/ld-elf/tls.exp | 2 +-
3 files changed, 12 insertions(+), 3 deletions(-)
diff --git a/ld/ChangeLog b/ld/ChangeLog
index b0f7cd2..47cc5a8 100644
--- a/ld/ChangeLog
+++ b/ld/ChangeLog
@@ -1,3 +1,9 @@
+2017-10-13 Alan Modra <amodra@gmail.com>
+
+ PR ld/22263
+ * testsuite/ld-elf/tls.exp: Link with -z text.
+ * testsuite/ld-elf/pr22263-1.rd: Test for tprel relocs.
+
2017-10-12 H.J. Lu <hongjiu.lu@intel.com>
PR ld/22263
diff --git a/ld/testsuite/ld-elf/pr22263-1.rd b/ld/testsuite/ld-elf/pr22263-1.rd
index 9a583fb..f29f7fe 100644
--- a/ld/testsuite/ld-elf/pr22263-1.rd
+++ b/ld/testsuite/ld-elf/pr22263-1.rd
@@ -1,2 +1,5 @@
-
-There are no relocations in this file.
+# tprel relocs are not needed in a PIE
+#failif
+#...
+.* R_.*_TP.*
+#pass
diff --git a/ld/testsuite/ld-elf/tls.exp b/ld/testsuite/ld-elf/tls.exp
index 9d64d6c..dd24071 100644
--- a/ld/testsuite/ld-elf/tls.exp
+++ b/ld/testsuite/ld-elf/tls.exp
@@ -40,7 +40,7 @@ if { [which $CC] == 0 } {
run_ld_link_tests [list \
[list \
"Build pr22263-1" \
- "-pie -e _start" \
+ "-pie -e _start -z text" \
"" \
"" \
{ pr22263-1a.c pr22263-1b.c } \