This is the mail archive of the binutils-cvs@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[binutils-gdb/binutils-2_29-branch] Check ELF section header only for ELF output


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=a388b7afeffad6411686d39dc1c62294da48a814

commit a388b7afeffad6411686d39dc1c62294da48a814
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Wed Aug 2 05:10:29 2017 -0700

    Check ELF section header only for ELF output
    
    When placing an orphan input section, check ELF section header only for
    ELF output.
    
    	PR ld/21884
    	* emultempl/elf32.em (gld${EMULATION_NAME}_place_orphan): Check
    	ELF section header only for ELF output.
    	* testsuite/ld-elf/pr21884.d: New test.
    	* testsuite/ld-elf/pr21884.t: Likewise.
    	* testsuite/ld-elf/pr21884a.s: Likewise.
    	* testsuite/ld-elf/pr21884b.s: Likewise.
    
    (cherry picked from commit db99ecc08f5b66fbe9cb72e90352c7f77ec71a6e)

Diff:
---
 ld/ChangeLog                   | 10 ++++++++++
 ld/emultempl/elf32.em          |  3 ++-
 ld/testsuite/ld-elf/pr21884.d  | 11 +++++++++++
 ld/testsuite/ld-elf/pr21884.t  |  7 +++++++
 ld/testsuite/ld-elf/pr21884a.s |  5 +++++
 ld/testsuite/ld-elf/pr21884b.s |  5 +++++
 6 files changed, 40 insertions(+), 1 deletion(-)

diff --git a/ld/ChangeLog b/ld/ChangeLog
index d16399b..88367da 100644
--- a/ld/ChangeLog
+++ b/ld/ChangeLog
@@ -1,3 +1,13 @@
+2017-08-02  H.J. Lu  <hongjiu.lu@intel.com>
+
+	PR ld/21884
+	* emultempl/elf32.em (gld${EMULATION_NAME}_place_orphan): Check
+	ELF section header only for ELF output.
+	* testsuite/ld-elf/pr21884.d: New test.
+	* testsuite/ld-elf/pr21884.t: Likewise.
+	* testsuite/ld-elf/pr21884a.s: Likewise.
+	* testsuite/ld-elf/pr21884b.s: Likewise.
+
 2017-07-31  Alan Modra  <amodra@gmail.com>
 
 	* ld.texinfo (plt-localentry): Revise.
diff --git a/ld/emultempl/elf32.em b/ld/emultempl/elf32.em
index d2551b6..75ded12 100644
--- a/ld/emultempl/elf32.em
+++ b/ld/emultempl/elf32.em
@@ -2136,7 +2136,8 @@ gld${EMULATION_NAME}_place_orphan (asection *s,
     }
 
   /* Look through the script to see where to place this section.  */
-  if (constraint == 0)
+  if (constraint == 0
+      && link_info.output_bfd->xvec->flavour == bfd_target_elf_flavour)
     for (os = lang_output_section_find (secname);
 	 os != NULL;
 	 os = next_matching_output_section_statement (os, 0))
diff --git a/ld/testsuite/ld-elf/pr21884.d b/ld/testsuite/ld-elf/pr21884.d
new file mode 100644
index 0000000..52cd2c1
--- /dev/null
+++ b/ld/testsuite/ld-elf/pr21884.d
@@ -0,0 +1,11 @@
+#source: pr21884a.s
+#source: pr21884b.s
+#ld: -T pr21884.t
+#objdump: -b binary -s
+#notarget: aarch64*-*-* arm*-*-* nds32*-*-*
+# Skip targets which can't change output format to binary.
+
+.*:     file format binary
+
+Contents of section .data:
+#pass
diff --git a/ld/testsuite/ld-elf/pr21884.t b/ld/testsuite/ld-elf/pr21884.t
new file mode 100644
index 0000000..d483911
--- /dev/null
+++ b/ld/testsuite/ld-elf/pr21884.t
@@ -0,0 +1,7 @@
+OUTPUT_FORMAT("binary")
+
+ENTRY(_main);
+SECTIONS {
+	. = 0;
+	.setup : { *(.setup) }
+}
diff --git a/ld/testsuite/ld-elf/pr21884a.s b/ld/testsuite/ld-elf/pr21884a.s
new file mode 100644
index 0000000..a3361b2
--- /dev/null
+++ b/ld/testsuite/ld-elf/pr21884a.s
@@ -0,0 +1,5 @@
+	.text
+	.globl	_main
+	.type _main,%function
+_main:
+	.dc.a bar
diff --git a/ld/testsuite/ld-elf/pr21884b.s b/ld/testsuite/ld-elf/pr21884b.s
new file mode 100644
index 0000000..e533837
--- /dev/null
+++ b/ld/testsuite/ld-elf/pr21884b.s
@@ -0,0 +1,5 @@
+	.text
+	.globl	bar
+	.type bar,%function
+bar:
+	.byte 0


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]