This is the mail archive of the
binutils-cvs@sourceware.org
mailing list for the binutils project.
[binutils-gdb] MIPS/GAS: Update `match_float_constant' and `match_operand' descriptions
- From: Maciej W.Rozycki <macro at sourceware dot org>
- To: bfd-cvs at sourceware dot org
- Date: 30 Jun 2017 14:41:36 -0000
- Subject: [binutils-gdb] MIPS/GAS: Update `match_float_constant' and `match_operand' descriptions
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=33f466961ce01a7db6dbec6b39aafb7af1855645
commit 33f466961ce01a7db6dbec6b39aafb7af1855645
Author: Maciej W. Rozycki <macro@imgtec.com>
Date: Fri Jun 30 15:39:26 2017 +0100
MIPS/GAS: Update `match_float_constant' and `match_operand' descriptions
Complement commit a92713e60ef4 ("Preparse MIPS instructions into
tokens"), <https://sourceware.org/ml/binutils/2013-07/msg00143.html>,
and update `match_float_constant' and `match_operand' function
descriptions according to semantics changes.
gas/
* config/tc-mips.c (match_float_constant): Update description.
(match_operand): Likewise.
Diff:
---
gas/ChangeLog | 5 +++++
gas/config/tc-mips.c | 10 +++++-----
2 files changed, 10 insertions(+), 5 deletions(-)
diff --git a/gas/ChangeLog b/gas/ChangeLog
index 371fca8..ffc661e 100644
--- a/gas/ChangeLog
+++ b/gas/ChangeLog
@@ -1,3 +1,8 @@
+2017-06-30 Maciej W. Rozycki <macro@imgtec.com>
+
+ * config/tc-mips.c (match_float_constant): Update description.
+ (match_operand): Likewise.
+
2017-06-30 Andrew Bennett <andrew.bennett@imgtec.com>
Maciej W. Rozycki <macro@imgtec.com>
diff --git a/gas/config/tc-mips.c b/gas/config/tc-mips.c
index e1e6b32..1d477a1 100644
--- a/gas/config/tc-mips.c
+++ b/gas/config/tc-mips.c
@@ -5937,9 +5937,9 @@ match_tied_reg_operand (struct mips_arg_info *arg, unsigned int other_regno)
return match_reg (arg, OP_REG_GP, ®no) && regno == other_regno;
}
-/* Read a floating-point constant from S for LI.S or LI.D. LENGTH is
- the length of the value in bytes (4 for float, 8 for double) and
- USING_GPRS says whether the destination is a GPR rather than an FPR.
+/* Try to match a floating-point constant from ARG for LI.S or LI.D.
+ LENGTH is the length of the value in bytes (4 for float, 8 for double)
+ and USING_GPRS says whether the destination is a GPR rather than an FPR.
Return the constant in IMM and OFFSET as follows:
@@ -6133,8 +6133,8 @@ match_vu0_suffix_operand (struct mips_arg_info *arg,
return TRUE;
}
-/* S is the text seen for ARG. Match it against OPERAND. Return the end
- of the argument text if the match is successful, otherwise return null. */
+/* Try to match a token from ARG against OPERAND. Consume the token
+ and return true on success, otherwise return false. */
static bfd_boolean
match_operand (struct mips_arg_info *arg,