This is the mail archive of the
binutils-cvs@sourceware.org
mailing list for the binutils project.
[binutils-gdb] x86: drop stray VEX opcode 82 references
- From: Jan Beulich <jbeulich at sourceware dot org>
- To: bfd-cvs at sourceware dot org
- Date: 23 Feb 2017 10:04:16 -0000
- Subject: [binutils-gdb] x86: drop stray VEX opcode 82 references
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=53c4d625d70138fb5b75f0e2ebae8ff363ed3d46
commit 53c4d625d70138fb5b75f0e2ebae8ff363ed3d46
Author: Jan Beulich <jbeulich@novell.com>
Date: Thu Feb 23 11:03:55 2017 +0100
x86: drop stray VEX opcode 82 references
No such ModR/M-less opcode has ever existed in public documentation
afaict, so I can't see why it had been added in the first place.
Furthermore opcode 77 is special only with implied prefix 0F.
Diff:
---
opcodes/ChangeLog | 5 +++++
opcodes/i386-dis.c | 8 ++++----
2 files changed, 9 insertions(+), 4 deletions(-)
diff --git a/opcodes/ChangeLog b/opcodes/ChangeLog
index 234b58b..ca2cf0e 100644
--- a/opcodes/ChangeLog
+++ b/opcodes/ChangeLog
@@ -1,3 +1,8 @@
+2017-02-23 Jan Beulich <jbeulich@suse.com>
+
+ * i386-dis.c (get_valid_dis386): Don't special case VEX opcode
+ 82. For 3-byte VEX only special case opcode 77 in VEX_0F space.
+
2017-02-21 Jan Beulich <jbeulich@suse.com>
* aarch64-asm.c (convert_bfc_to_bfm): Copy operand 0 to operand
diff --git a/opcodes/i386-dis.c b/opcodes/i386-dis.c
index 97a18ba..108f0e3 100644
--- a/opcodes/i386-dis.c
+++ b/opcodes/i386-dis.c
@@ -12771,8 +12771,8 @@ get_valid_dis386 (const struct dis386 *dp, disassemble_info *info)
vindex = *codep++;
dp = &vex_table[vex_table_index][vindex];
end_codep = codep;
- /* There is no MODRM byte for VEX [82|77]. */
- if (vindex != 0x77 && vindex != 0x82)
+ /* There is no MODRM byte for VEX0F 77. */
+ if (vex_table_index != VEX_0F || vindex != 0x77)
{
FETCH_DATA (info, codep + 1);
modrm.mod = (*codep >> 6) & 3;
@@ -12814,8 +12814,8 @@ get_valid_dis386 (const struct dis386 *dp, disassemble_info *info)
vindex = *codep++;
dp = &vex_table[dp->op[1].bytemode][vindex];
end_codep = codep;
- /* There is no MODRM byte for VEX [82|77]. */
- if (vindex != 0x77 && vindex != 0x82)
+ /* There is no MODRM byte for VEX 77. */
+ if (vindex != 0x77)
{
FETCH_DATA (info, codep + 1);
modrm.mod = (*codep >> 6) & 3;