This is the mail archive of the
binutils-cvs@sourceware.org
mailing list for the binutils project.
[binutils-gdb] Don't give an internal error for unsupported relocations.
- From: Cary Coutant <ccoutant at sourceware dot org>
- To: bfd-cvs at sourceware dot org
- Date: 15 Feb 2017 08:55:51 -0000
- Subject: [binutils-gdb] Don't give an internal error for unsupported relocations.
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=f9029569740a8ef2a66b3578fa6c89c0ab62be52
commit f9029569740a8ef2a66b3578fa6c89c0ab62be52
Author: Vladimir Radosavljevic <Vladimir.Radosavljevic@imgtec.com>
Date: Wed Feb 15 00:55:04 2017 -0800
Don't give an internal error for unsupported relocations.
gold/
* mips.cc (Target_mips::Scan::get_reference_flags): Remove
gold_unreachable from default case.
Diff:
---
gold/ChangeLog | 25 +++++++++++++++----------
gold/mips.cc | 1 -
2 files changed, 15 insertions(+), 11 deletions(-)
diff --git a/gold/ChangeLog b/gold/ChangeLog
index 9b8abc7..3f41834 100644
--- a/gold/ChangeLog
+++ b/gold/ChangeLog
@@ -1,16 +1,21 @@
2017-02-15 Vladimir Radosavljevic <Vladimir.Radosavljevic@imgtec.com>
+ * mips.cc (Target_mips::Scan::get_reference_flags): Remove
+ gold_unreachable from default case.
+
+2017-02-15 Vladimir Radosavljevic <Vladimir.Radosavljevic@imgtec.com>
+
PR gold/21111
- * mips.cc (Mips_relocate_functions::relhigher): New method.
- (Mips_relocate_functions::relhighest): Likewise.
- (mips_get_size_for_reloc): Add support for relocs: R_MIPS_HIGHER and
- R_MIPS_HIGHEST.
- (Target_mips::Scan::local): Add support for relocs: R_MIPS_HIGHER,
- R_MIPS_HIGHEST, R_MICROMIPS_HIGHER and R_MICROMIPS_HIGHEST.
- (Target_mips::Scan::global): Likewise.
- (Target_mips::Scan::get_reference_flags): Likewise.
- (Target_mips::Relocate::relocate): Call static methods for resolving
- HIGHER and HIGHEST relocations.
+ * mips.cc (Mips_relocate_functions::relhigher): New method.
+ (Mips_relocate_functions::relhighest): Likewise.
+ (mips_get_size_for_reloc): Add support for relocs: R_MIPS_HIGHER and
+ R_MIPS_HIGHEST.
+ (Target_mips::Scan::local): Add support for relocs: R_MIPS_HIGHER,
+ R_MIPS_HIGHEST, R_MICROMIPS_HIGHER and R_MICROMIPS_HIGHEST.
+ (Target_mips::Scan::global): Likewise.
+ (Target_mips::Scan::get_reference_flags): Likewise.
+ (Target_mips::Relocate::relocate): Call static methods for resolving
+ HIGHER and HIGHEST relocations.
2017-02-03 Rahul Chaudhry <rahulchaudhry@google.com>
diff --git a/gold/mips.cc b/gold/mips.cc
index 7b19e4c..95bf6db 100644
--- a/gold/mips.cc
+++ b/gold/mips.cc
@@ -12334,7 +12334,6 @@ Target_mips<size, big_endian>::Scan::get_reference_flags(
case elfcpp::R_MIPS_COPY:
case elfcpp::R_MIPS_JUMP_SLOT:
default:
- gold_unreachable();
// Not expected. We will give an error later.
return 0;
}