This is the mail archive of the
binutils-cvs@sourceware.org
mailing list for the binutils project.
[binutils-gdb] NDS32/BFD: Correct an aliasing error in `nds32_elf_check_relocs'
- From: Maciej W.Rozycki <macro at sourceware dot org>
- To: bfd-cvs at sourceware dot org
- Date: 18 Oct 2016 03:44:17 -0000
- Subject: [binutils-gdb] NDS32/BFD: Correct an aliasing error in `nds32_elf_check_relocs'
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=61034b0b6acc6ff72def5f5ecdbe628edc5d67ea
commit 61034b0b6acc6ff72def5f5ecdbe628edc5d67ea
Author: Maciej W. Rozycki <macro@imgtec.com>
Date: Tue Oct 18 04:34:36 2016 +0100
NDS32/BFD: Correct an aliasing error in `nds32_elf_check_relocs'
Fix an aliasing build error:
cc1: warnings being treated as errors
.../bfd/elf32-nds32.c: In function 'nds32_elf_check_relocs':
.../bfd/elf32-nds32.c:6644: warning: dereferencing type-punned pointer will break strict-aliasing rules
make[3]: *** [elf32-nds32.lo] Error 1
in a way following commit 6edfbbad0864 ("Fix up gcc4.1 aliasing
warnings"), <https://sourceware.org/ml/binutils/2005-10/msg00071.html>.
bfd/
* elf32-nds32.c (nds32_elf_check_relocs): Avoid aliasing warning
from GCC.
Diff:
---
bfd/ChangeLog | 5 +++++
bfd/elf32-nds32.c | 5 +++--
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 4dc5256..1e34b19 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,5 +1,10 @@
2016-10-18 Maciej W. Rozycki <macro@imgtec.com>
+ * elf32-nds32.c (nds32_elf_check_relocs): Avoid aliasing warning
+ from GCC.
+
+2016-10-18 Maciej W. Rozycki <macro@imgtec.com>
+
* elf32-arm.c (elf32_arm_update_relocs): Rename `index' local
variable to `reloc_index'.
diff --git a/bfd/elf32-nds32.c b/bfd/elf32-nds32.c
index 81195a4..fdeada7 100644
--- a/bfd/elf32-nds32.c
+++ b/bfd/elf32-nds32.c
@@ -6629,6 +6629,7 @@ nds32_elf_check_relocs (bfd *abfd, struct bfd_link_info *info,
else
{
asection *s;
+ void *vpp;
Elf_Internal_Sym *isym;
isym = bfd_sym_from_r_symndx (&htab->sym_cache, abfd, r_symndx);
@@ -6640,8 +6641,8 @@ nds32_elf_check_relocs (bfd *abfd, struct bfd_link_info *info,
if (s == NULL)
return FALSE;
- head = ((struct elf_nds32_dyn_relocs **)
- &elf_section_data (s)->local_dynrel);
+ vpp = &elf_section_data (s)->local_dynrel;
+ head = (struct elf_nds32_dyn_relocs **) vpp;
}
p = *head;