This is the mail archive of the binutils-cvs@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[binutils-gdb] [GOLD] two more fall-through comments


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=c25aa1e114af2be29bb8b69641673ec2baa8c6bd

commit c25aa1e114af2be29bb8b69641673ec2baa8c6bd
Author: Alan Modra <amodra@gmail.com>
Date:   Thu Oct 6 15:54:38 2016 +1030

    [GOLD] two more fall-through comments
    
    	* powerpc.cc (Target_powerpc::Relocate::relocate): Add fall
    	through comment.
    	* tilegx.cc (Target_tilegx::Relocate::relocate): Likewise.

Diff:
---
 gold/ChangeLog  | 6 ++++++
 gold/powerpc.cc | 1 +
 gold/tilegx.cc  | 6 ++----
 3 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/gold/ChangeLog b/gold/ChangeLog
index 8b917b5..ae86f66 100644
--- a/gold/ChangeLog
+++ b/gold/ChangeLog
@@ -1,5 +1,11 @@
 2016-10-06  Alan Modra  <amodra@gmail.com>
 
+	* powerpc.cc (Target_powerpc::Relocate::relocate): Add fall
+	through comment.
+	* tilegx.cc (Target_tilegx::Relocate::relocate): Likewise.
+
+2016-10-06  Alan Modra  <amodra@gmail.com>
+
 	* aarch64.cc: Spell fall through comments as "// Fall through.".
 	* arm.cc: Likewise.
 	* mips.cc: Likewise.
diff --git a/gold/powerpc.cc b/gold/powerpc.cc
index d286f70..1e95d5b 100644
--- a/gold/powerpc.cc
+++ b/gold/powerpc.cc
@@ -8007,6 +8007,7 @@ Target_powerpc<size, big_endian>::Relocate::relocate(
 	  maybe_dq_reloc = true;
 	  break;
 	}
+      // Fall through.
     case elfcpp::R_POWERPC_ADDR16:
     case elfcpp::R_POWERPC_REL16:
     case elfcpp::R_PPC64_TOC16:
diff --git a/gold/tilegx.cc b/gold/tilegx.cc
index ee262d1..03b1a50 100644
--- a/gold/tilegx.cc
+++ b/gold/tilegx.cc
@@ -4649,10 +4649,8 @@ Target_tilegx<size, big_endian>::Relocate::relocate(
               } // else if (opt_t == tls::TLSOPT_TO_LE)
                 //   both GD/IE are turned into LE, which
                 //   is absolute relocation.
-                //
-                //  |  go through
-                //  |
-                //  V
+                // Fall through.
+
             // LE
             //
             // tp


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]