[binutils-gdb] MIPS/GAS: Remove extraneous `install_insn' call from `append_insn'

[Maciej W.Rozycki <macro at sourceware dot org>]

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=b8bca85b334b231be6184a0a9a0e7ded6593569b

commit b8bca85b334b231be6184a0a9a0e7ded6593569b
Author: Maciej W. Rozycki <macro@imgtec.com>
Date:   Fri Jul 8 14:37:46 2016 +0100

    MIPS/GAS: Remove extraneous `install_insn' call from `append_insn'
    
    Complement:
    
    commit 1e91584932efd70020c8c98037d0cb93a0552a20
    Author: Richard Sandiford <rdsandiford@googlemail.com>
    Date:   Wed Mar 9 09:17:02 2005 +0000
    
    <https://sourceware.org/ml/binutils/2005-03/msg00217.html>, ("Rework
    MIPS nop-insertion code, add -mfix-vr4130 [5/11]"), and remove a call to
    `install_insn' from `append_insn', which as from that change has become
    redundant.  This is because such a call, to place an instruction's bit
    pattern in output, is already made from `move_insn', called from
    `add_relaxed_insn' or `add_fixed_insn' as appropriate, either of which
    now always is and has to be made from `append_insn' before the repeated
    call to `install_insn' is made.  Previously the place where this second
    invocation is made was the only one where the output stream was updated,
    although the update was made inline rather than with a function call.
    
    Remove the repeated call then, to reclaim some performance.
    
    	gas/
    	* config/tc-mips.c (append_insn): Remove extraneous
    	`install_insn' call.

Diff:
---
 gas/config/tc-mips.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/gas/config/tc-mips.c b/gas/config/tc-mips.c
index eb8b26b..b7997c7 100644
--- a/gas/config/tc-mips.c
+++ b/gas/config/tc-mips.c
@@ -7481,7 +7481,6 @@ append_insn (struct mips_cl_insn *ip, expressionS *address_expr,
 	    ip->fixp[i]->fx_tcbit = 1;
 	  }
     }
-  install_insn (ip);
 
   /* Update the register mask information.  */
   mips_gprmask |= gpr_read_mask (ip) | gpr_write_mask (ip);