This is the mail archive of the
binutils-cvs@sourceware.org
mailing list for the binutils project.
[binutils-gdb] MIPS/GAS/testsuite: Reenable disabled external BEQ tests
- From: Maciej W.Rozycki <macro at sourceware dot org>
- To: bfd-cvs at sourceware dot org
- Date: 2 Jul 2016 22:51:40 -0000
- Subject: [binutils-gdb] MIPS/GAS/testsuite: Reenable disabled external BEQ tests
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=f26c9c2eaf6fbfeae03cc7926e4a5fca0bba1ae5
commit f26c9c2eaf6fbfeae03cc7926e4a5fca0bba1ae5
Author: Maciej W. Rozycki <macro@imgtec.com>
Date: Sat Jul 2 22:19:15 2016 +0100
MIPS/GAS/testsuite: Reenable disabled external BEQ tests
Complement:
commit bad36eacdad37042c4efb1c5fbf48476b47de82b
Author: Daniel Jacobowitz <drow@false.org>
Date: Wed Nov 23 14:04:18 2005 +0000
<https://sourceware.org/ml/binutils/2005-11/msg00324.html>,
("R_MIPS_PC16, again"), and reenable external BEQ tests, the remaining
subset missed from the set of branch tests previously disabled with:
commit 6f171daac941741e5fa904f6e462adb75a595495
Author: Alexandre Oliva <aoliva@redhat.com>
Date: Thu Dec 12 04:40:22 2002 +0000
<https://sourceware.org/ml/binutils/2002-11/msg00631.html>, ("mips:
branches to external labels are broken").
gas/
* testsuite/gas/mips/beq.s: Uncomment branches to undefined
symbols.
* testsuite/gas/mips/beq.d: Update accordingly.
* testsuite/gas/mips/mipsr6@beq.d: Likewise.
* testsuite/gas/mips/micromips@beq.d: Likewise.
Diff:
---
gas/ChangeLog | 8 ++++++++
gas/testsuite/gas/mips/beq.d | 12 ++++++------
gas/testsuite/gas/mips/beq.s | 4 ++--
gas/testsuite/gas/mips/micromips@beq.d | 5 +++++
gas/testsuite/gas/mips/mipsr6@beq.d | 6 ++++++
5 files changed, 27 insertions(+), 8 deletions(-)
diff --git a/gas/ChangeLog b/gas/ChangeLog
index 8acbbea..7ab0b28 100644
--- a/gas/ChangeLog
+++ b/gas/ChangeLog
@@ -1,5 +1,13 @@
2016-07-02 Maciej W. Rozycki <macro@imgtec.com>
+ * testsuite/gas/mips/beq.s: Uncomment branches to undefined
+ symbols.
+ * testsuite/gas/mips/beq.d: Update accordingly.
+ * testsuite/gas/mips/mipsr6@beq.d: Likewise.
+ * testsuite/gas/mips/micromips@beq.d: Likewise.
+
+2016-07-02 Maciej W. Rozycki <macro@imgtec.com>
+
* testsuite/gas/mips/mips.exp: Restrict 64-bit `branch-mips'
tests to NewABI targets.
diff --git a/gas/testsuite/gas/mips/beq.d b/gas/testsuite/gas/mips/beq.d
index 4da3d12..17c1ab1 100644
--- a/gas/testsuite/gas/mips/beq.d
+++ b/gas/testsuite/gas/mips/beq.d
@@ -36,10 +36,10 @@ Disassembly of section \.text:
[0-9a-f]+ <[^>]*> jal 0+0000 <.*>
[ ]*20060: (MIPS_JMP|JMPADDR|R_MIPS_26) \.text
[0-9a-f]+ <[^>]*> nop
-#[0-9a-f]+ <[^>]*> b 0+20068 <.*\+0x20068>
-#[ ]*20068: .*16 external_label
-#[0-9a-f]+ <[^>]*> nop
-#[0-9a-f]+ <[^>]*> bal 0+20070 <.*\+0x20070>
-#[ ]*20070: .*16 external_label
-#[0-9a-f]+ <[^>]*> nop
+[0-9a-f]+ <[^>]*> b 0+20068 <.*\+0x20068>
+[ ]*20068: .*16 external_label
+[0-9a-f]+ <[^>]*> nop
+[0-9a-f]+ <[^>]*> bal 0+20070 <.*\+0x20070>
+[ ]*20070: .*16 external_label
+[0-9a-f]+ <[^>]*> nop
\.\.\.
diff --git a/gas/testsuite/gas/mips/beq.s b/gas/testsuite/gas/mips/beq.s
index bed6916..c37106a 100644
--- a/gas/testsuite/gas/mips/beq.s
+++ b/gas/testsuite/gas/mips/beq.s
@@ -20,8 +20,8 @@ text_label:
.endif
# Branch to an external label.
-# b external_label
-# bal external_label
+ b external_label
+ bal external_label
# Force at least 8 (non-delay-slot) zero bytes, to make 'objdump' print ...
.align 2
diff --git a/gas/testsuite/gas/mips/micromips@beq.d b/gas/testsuite/gas/mips/micromips@beq.d
index 9f099e5..29dcbc3 100644
--- a/gas/testsuite/gas/mips/micromips@beq.d
+++ b/gas/testsuite/gas/mips/micromips@beq.d
@@ -45,5 +45,10 @@ Disassembly of section \.text:
[0-9a-f]+ <[^>]*> 4060 fffe bal 0002004e <text_label\+0x2004e>
2004e: R_MICROMIPS_PC16_S1 text_label
[0-9a-f]+ <[^>]*> 0000 0000 nop
+[0-9a-f]+ <[^>]*> 9400 fffe b 00020056 <text_label\+0x20056>
+ 20056: R_MICROMIPS_PC16_S1 external_label
[0-9a-f]+ <[^>]*> 0c00 nop
+[0-9a-f]+ <[^>]*> 4060 fffe bal 0002005c <text_label\+0x2005c>
+ 2005c: R_MICROMIPS_PC16_S1 external_label
+[0-9a-f]+ <[^>]*> 0000 0000 nop
\.\.\.
diff --git a/gas/testsuite/gas/mips/mipsr6@beq.d b/gas/testsuite/gas/mips/mipsr6@beq.d
index b5fec4c..c334c57 100644
--- a/gas/testsuite/gas/mips/mipsr6@beq.d
+++ b/gas/testsuite/gas/mips/mipsr6@beq.d
@@ -38,4 +38,10 @@ Disassembly of section \.text:
[0-9a-f]+ <[^>]*> bnez a0,0+0050 <.*>
[ ]*50: .*R_MIPS_PC16 text_label
[0-9a-f]+ <[^>]*> nop
+[0-9a-f]+ <[^>]*> b 0+0058 <.*>
+[ ]*58: .*R_MIPS_PC16 external_label
+[0-9a-f]+ <[^>]*> nop
+[0-9a-f]+ <[^>]*> bal 0+0060 <.*>
+[ ]*60: .*R_MIPS_PC16 external_label
+[0-9a-f]+ <[^>]*> nop
\.\.\.