This is the mail archive of the
binutils-cvs@sourceware.org
mailing list for the binutils project.
[binutils-gdb] Skip ELF STT_COMMON linker tests if shared libraries are not supported.
- From: Nick Clifton <nickc at sourceware dot org>
- To: bfd-cvs at sourceware dot org
- Date: 3 May 2016 09:45:34 -0000
- Subject: [binutils-gdb] Skip ELF STT_COMMON linker tests if shared libraries are not supported.
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=a2076b34e146a1f181ef58b5954815571fbcd6c6
commit a2076b34e146a1f181ef58b5954815571fbcd6c6
Author: Senthil Kumar Selvaraj <senthil_kumar.selvaraj@atmel.com>
Date: Tue May 3 10:44:35 2016 +0100
Skip ELF STT_COMMON linker tests if shared libraries are not supported.
* testsuite/ld-elfcomm/elfcomm.exp: Check for shared lib support
before running STT_COMMON tests.
Diff:
---
ld/ChangeLog | 5 +++++
ld/testsuite/ld-elfcomm/elfcomm.exp | 8 ++++++++
2 files changed, 13 insertions(+)
diff --git a/ld/ChangeLog b/ld/ChangeLog
index aecf581..92596b7 100644
--- a/ld/ChangeLog
+++ b/ld/ChangeLog
@@ -1,3 +1,8 @@
+2016-05-03 Senthil Kumar Selvaraj <senthil_kumar.selvaraj@atmel.com>
+
+ * testsuite/ld-elfcomm/elfcomm.exp: Check for shared lib support
+ before running STT_COMMON tests.
+
2016-04-29 H.J. Lu <hongjiu.lu@intel.com>
* config/default.exp (NOPIE_CFLAGS): Download source only on
diff --git a/ld/testsuite/ld-elfcomm/elfcomm.exp b/ld/testsuite/ld-elfcomm/elfcomm.exp
index 926b98c..fd32e02 100644
--- a/ld/testsuite/ld-elfcomm/elfcomm.exp
+++ b/ld/testsuite/ld-elfcomm/elfcomm.exp
@@ -246,6 +246,14 @@ if { [dump_common1 $test1c2] } {
#
# The following tests are for when we are generating STT_COMMON symbols only.
#
+# Handling of -z common and -z nocommon flags is enabled only if
+# $GENERATE_SHLIB_SCRIPT is turned on in emulparams i.e. shared
+# libraries are supported.
+
+if ![check_shared_lib_support] {
+ return
+}
+
stt_common_test "-static -e 0" "static link of common symbols"
stt_common_test "-shared" "shared link of common symbols"
stt_common_test "-pie" "position independent link of common symbols"