This is the mail archive of the
binutils-cvs@sourceware.org
mailing list for the binutils project.
[binutils-gdb/binutils-2_25-branch] Fix garbage collection of common symbols for powerpc64
- From: Alan Modra <amodra at sourceware dot org>
- To: bfd-cvs at sourceware dot org
- Date: 11 Feb 2015 12:53:40 -0000
- Subject: [binutils-gdb/binutils-2_25-branch] Fix garbage collection of common symbols for powerpc64
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=c1b7d37c0d6bd15b1a154aef0c764a4350dd0f22
commit c1b7d37c0d6bd15b1a154aef0c764a4350dd0f22
Author: Alan Modra <amodra@gmail.com>
Date: Tue Jan 20 11:06:28 2015 +1030
Fix garbage collection of common symbols for powerpc64
I forgot powerpc64 has its own gc_mark_dynamic_ref.
PR ld/17615
* elf64-ppc.c (ppc64_elf_gc_mark_dynamic_ref): Don't drop
ELF_COMMON_DEF syms.
Diff:
---
bfd/ChangeLog | 5 +++++
bfd/elf64-ppc.c | 2 +-
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 0300b59..cba389e 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,6 +1,11 @@
2015-02-11 Alan Modra <amodra@gmail.com>
Apply from master.
+ 2015-01-20 Alan Modra <amodra@gmail.com>
+ PR ld/17615
+ * elf64-ppc.c (ppc64_elf_gc_mark_dynamic_ref): Don't drop
+ ELF_COMMON_DEF syms.
+
2015-01-19 Alan Modra <amodra@gmail.com>
PR 17165
* elf-bfd.h (ELF_COMMON_DEF_P): Note that this might be true for
diff --git a/bfd/elf64-ppc.c b/bfd/elf64-ppc.c
index 88ae80c..318f41a 100644
--- a/bfd/elf64-ppc.c
+++ b/bfd/elf64-ppc.c
@@ -6232,7 +6232,7 @@ ppc64_elf_gc_mark_dynamic_ref (struct elf_link_hash_entry *h, void *inf)
if ((eh->elf.root.type == bfd_link_hash_defined
|| eh->elf.root.type == bfd_link_hash_defweak)
&& (eh->elf.ref_dynamic
- || (eh->elf.def_regular
+ || ((eh->elf.def_regular || ELF_COMMON_DEF_P (&eh->elf))
&& ELF_ST_VISIBILITY (eh->elf.other) != STV_INTERNAL
&& ELF_ST_VISIBILITY (eh->elf.other) != STV_HIDDEN
&& (!info->executable