This is the mail archive of the mailing list for the Archer project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: change for gdb index

On Fri, 2 Jul 2010, Tom Tromey wrote:

Tom> For a symbol file X, it looks for X.gdb-index.

Roland> It's not clear to me what that means in the separate .debug case.
Roland> If "symbol file" means the file with the DWARF, then that file is
Roland> foo.debug so you will be looking for foo.debug.gdb-index.

Right, that is what we do.

Roland> I think it is preferable for the packaging not to add the new symlinks.
Roland> It doesn't seem like we really need them, since you can look at the
Roland> .build-id/xx/yyy.debug symlink target name instead.

Sounds good.

In this case I think the most recent patch I sent is the one to use.

So it would be this patch, right?

---	2010-06-29 16:19:42.000000000 -0600
+++	2010-06-30 14:41:19.000000000 -0600
@@ -96,6 +96,15 @@
   chmod 444 "$1" || exit

+# Create a .gdb-index file for $1.
+  local f="$1"
+  local d="${f%/*}"
+  # We don't care if gdb gives an error.
+  gdb --batch-silent -ex "file $f" -ex "maintenance save-gdb-index $d" > /dev/null 2>&1
 # Make a relative symlink to $1 called $3$2
 shopt -s extglob
@@ -224,6 +233,8 @@
     chmod u-w "$f"

+  make_gdb_index "$debugfn"
   if [ -n "$id" ]; then
     make_id_link "$id" "$dn/$(basename $f)"
     make_id_link "$id" "/usr/lib/debug$dn/$bn" .debug

Is the necessary patch(es) already in rawhide gdb, I dont see anything obviously related in gdb changelogs?

One thing this does is that it forces rpm-build to depend on gdb, which hardly is the end of the world, just something to note.

- Panu -

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]