This is the mail archive of the
mailing list for the Archer project.
[next-over-throw2] exception_resume_breakpoint comments
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: archer at sourceware dot org
- Date: Thu, 29 Apr 2010 18:47:22 +0200
- Subject: [next-over-throw2] exception_resume_breakpoint comments
on this branch I have just seen suspicious:
insert_exception_resume_breakpoint (struct thread_info *tp,
struct block *b,
struct frame_info *frame,
struct symbol *sym)
- does not use TP at all.
Then clear_thread_inferior_resources now clears tp->step_resume_breakpoint.
To make tp->exception_resume_breakpoint on par with existing
tp->step_resume_breakpoint IMO clear_thread_inferior_resources should clear
Unrelated bug is that both these breakpoints should be set as thread-specific.
Another unrelated bug is that on a thread exit thread-specific breakpoints are
not deleted (one may ask if they should be deleted, though). Fix of these two
bugs would simplify clear_thread_inferior_resources to remove even the
tp->step_resume_breakpoint handling from there.
To get back in the scope of this specific patch I would just implement:
# To make tp->exception_resume_breakpoint on par with existing
# tp->step_resume_breakpoint IMO clear_thread_inferior_resources should clear
# even tp->exception_resume_breakpoint.