This is the mail archive of the
mailing list for the Archer project.
Re: [python][patch] Info about base class in gdb.Type
- From: Richard Ward <richard dot j dot ward1 at googlemail dot com>
- To: Phil Muldoon <pmuldoon at redhat dot com>
- Cc: Project Archer <archer at sourceware dot org>
- Date: Mon, 02 Nov 2009 19:50:15 +0000
- Subject: Re: [python][patch] Info about base class in gdb.Type
- References: <1245333024.4351.12.camel@elemental-lin> <4AEEE5A6.email@example.com> <4AEEF644.firstname.lastname@example.org>
- Reply-to: richard dot j dot ward1 at googlemail dot com
On Mon, 2009-11-02 at 15:09 +0000, Phil Muldoon wrote:
> On 11/02/2009 01:59 PM, Phil Muldoon wrote:
> > On 06/18/2009 02:50 PM, Richard Ward wrote:
> >> A small patch to add a bool indicating if a class member as returned by
> >> the fields method on a gdb.Type represents a base class.
> >> PS. asked about this (and other patches I'll hopefully be sending) on
> >> IRC and was told to sign the copyright waiver thing for the FSF before
> >> submitting. Not sure if I need to give any info on that but the FSF say
> >> they have it now.
> >> 2009-05-28 Richard Ward<email@example.com>
> >> * gdb/python/python-type.c
> >> convert_field adds a new bool entry "base_class" indicating
> >> whether the field represents a base class
> >> * gdb/doc/gdb.texinfo:
> >> updated to refelect the above.
> > Richard,
> > I have a patch ready for upstream that depends on your patch. As you
> > have papers on file, can you submit this to FSF GDB upstream at
> > firstname.lastname@example.org?
> Oops part of my patch fixes a buglet in your is_base_class patch; the
> other section adds the beginnings of a testsuite for Python types. I
> can just merge the patches, ChangeLogs and submit it all upstream as one
> patch. What do you think?
Sounds fine to me.
The only thing is I was rather hoping that my email would appear in
either the ChangeLogs or the version control logs (I'm looking for work
at the moment, and if I say in my CV or an interview that I submitted
some small patches to gdb I'd like to be able to prove it). Will that be
the case? If not then its not the end of the world.