This is the mail archive of the mailing list for the Archer project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

regression in remote.c in remote_threads_info for qfThreadInfo/qsThreadInfowith the introduction of read_ptid

The use of read_ptid replaced use of strtoul. strtoul eats leading whitespace, read_ptid does not.

The protocol documentation explicitly provides for the existence of whitespace: `m thread-id' and `m thread-id,thread-id...'

I believe the following patch solves the problem without any ill effects. My fix, however, is localized to remote_threads_info and so would not deal with any other regressions.


diff --git a/gdb/remote.c b/gdb/remote.c
index 4c58abb..310c8f7 100644
--- a/gdb/remote.c
+++ b/gdb/remote.c
@@ -2239,6 +2239,9 @@ remote_threads_info (struct target_ops *ops)
while (*bufp++ == 'm') /* reply contains one or more TID */
+ if (*bufp == ' ')
+ bufp++;
new_thread = read_ptid (bufp, &bufp);


Origin of the problem:

Offending commit: b34f362bd3708bb786d64dc819ad2b4b1f84f55f


hunk before the patch:;a=blob;f=gdb/remote.c;h=3433e9d2ffed5f77b0035722b76e77c234df376e;hb=3433e9d2ffed5f77b0035722b76e77c234df376e#l1971

hunk after the patch:;a=blob;f=gdb/remote.c;h=dfae2f68386662a52e3c26b424596010ea229d52;hb=dfae2f68386662a52e3c26b424596010ea229d52#l2056


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]