This is the mail archive of the archer@sourceware.org mailing list for the Archer project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [2/2][RFA][7.0] Rename Python testcase files to be 8.3 safe


Em Segunda-feira 03 Agosto 2009 14:52:57 Tom Tromey escreveu:
> >>>>> "Thiago" == Thiago Jung Bauermann <thiago.bauermann@gmail.com>
> >>>>> writes:
>
> Thiago> #	renamed:    testsuite/gdb.python/python-mi.exp ->
> testsuite/gdb.python/mi.exp
>
> It is actually useful to have all .exp files have a globally unique
> name.  That way you can run just a single file by passing its basename
> to runtest.
>
> I didn't check to see if any of these basenames clash -- but they seem a
> bit generic.
>
> So, how about py-mi.exp?

I forgot to mention that before I submitted the patch, I verified that

% make check RUNTESTFLAGS=gdb.python/foo.exp

works as expected, even if there's a foo.exp somewhere else (i.e., that other 
foo.exp will not be run). Do you still prefer unique basenames?

> Otherwise it is all fine by me.

I'll hold on this patch while I see what should be done regarding the 
gdb/python/*.[ch] files. I'm not liking fnchange.lst much, will have to raise 
this topic upstream...
-- 
[]'s
Thiago Jung Bauermann


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]