This is the mail archive of the
mailing list for the Archer project.
Re: [python][rfc] Attempt to print the base class if a there is no Python pretty-printer for a derived class.
- From: Tom Tromey <tromey at redhat dot com>
- To: Phil Muldoon <pmuldoon at redhat dot com>
- Cc: Project Archer <archer at sourceware dot org>
- Date: Fri, 27 Mar 2009 11:47:33 -0600
- Subject: Re: [python][rfc] Attempt to print the base class if a there is no Python pretty-printer for a derived class.
- References: <49CD0730.email@example.com> <firstname.lastname@example.org><49CD1045.email@example.com>
- Reply-to: Tom Tromey <tromey at redhat dot com>
>>>>> "Phil" == Phil Muldoon <firstname.lastname@example.org> writes:
Phil> It works in so much as this is a "do or continue with the old logic";
Phil> the existing Python pretty-printers would handle these if they were
Phil> called, no?
My understanding of the current code is that if you have a repeated
virtual base class, it will only be printed once.
So, the test case here would be to have a pretty-printer for the
virtual base -- then, make sure that it is only invoked a single time.
Phil> I was thinking of a documentation patch in the narrative
Phil> regarding printer selection too. But is this just going to be
Phil> superfluous to the reader?
My first reaction is that we don't need a documentation update for
this. It is just a simple extension of the generic logic to a
different case of printing -- this change is a technical one, related
to the implementation, not really a different use.