This is the mail archive of the
mailing list for the Archer project.
[delayed-symfile] make print conditions parallel
- From: Tom Tromey <tromey at redhat dot com>
- To: Project Archer <archer at sourceware dot org>
- Date: Fri, 06 Mar 2009 18:22:41 -0700
- Subject: [delayed-symfile] make print conditions parallel
- Reply-to: Tom Tromey <tromey at redhat dot com>
Jan pointed out some regressions in F11 caused by spurious "no
debugging symbols found" prints. I could only reproduce with all the
RPM patches applied.
I tracked this down to a missing clause on a condition. This patch
makes all the prints in this function have the same condition, so that
this particular message does not appear unless other messages already
I'm checking this in on the delayed-symfile branch.
Jan, this fixed the regressions you mentioned to me. I'm running a
full regression test for the delayed-symfile branch, just to be
careful -- but since I could only reproduce the failure with more
things applied, I doubt this will do much. I'm going to push this
once the tests are finished.
2009-03-06 Tom Tromey <email@example.com>
* symfile.c (symbol_file_add_with_addrs_or_offsets): Make "no
debugging symbols found" message use same condition as other
diff --git a/gdb/symfile.c b/gdb/symfile.c
index a95a8c1..92272a4 100644
@@ -1066,7 +1066,8 @@ symbol_file_add_with_addrs_or_offsets (bfd *abfd, int from_tty,
/* has_any_debug_symbols is not fully compatible with the former calls which
would just be needlessly expensive here. */
- if (print_symbol_loading && !has_any_debug_symbols (objfile) && mainline)
+ if ((from_tty || info_verbose) && print_symbol_loading
+ && !has_any_debug_symbols (objfile) && mainline)
printf_unfiltered (_("(no debugging symbols found)"));