This is the mail archive of the
mailing list for the Archer project.
Re: [keiths-expr-cumulative] Regressions [Re: New branch for Fedora11 merges]
Jan Kratochvil wrote:
On Fri, 27 Feb 2009 23:03:26 +0100, Sami Wagiaalla wrote:
Sami Wagiaalla wrote:
I introduced this problem earlier when i was trying to resolve a
conflict that I had with a patch of Jan's.
60eb8684d0d85d0884aca7a2f013e5eb16a51d47I have check in a fix for this.
I'll check in a fix for this. The issue is that sometimes a function
Die might now have high/low pc tags but it has an abstract origin tag
pointing to useful namespace information.
It still has a lot of regressions (tried archer-keiths-expr-cumulative) like:
info function operator\*(^M
memory clobbered past end of allocated block^M
FAIL: gdb.cp/cplusfuncs.exp: info function for "operator%(" (timeout)
(at least on F10.x86_64 using mcheck: LDFLAGS="-lmcheck" ./configure...).
Possible quick fix is attached (not checked-in) - my code moved into
explore_abstract_origin() needs to know (the `die_children' count is only read)
the number of children DIEs - to allocate appropriately sized array.
I have committed your patch. Thanks.
Unfortunately even after this attached fix the branch is FAILing on:
+FAIL: gdb.cp/namespace-using.exp: print _a
+FAIL: gdb.cp/namespace-using.exp: print x
Are these the only regressions left ?
* Every test name should be unique - this is the reason the names exist.
You do not follow it.
* You use `send_gdb' without waiting on the response of each command - some
wait on "$gdb_prompt $". The waiting can be usually done by `gdb_test', in
more complicated cases by `gdb_test_multiple'. Otherwise the results get
random as dejagnu is not in sync with the GDB output.
* There are even specific library functions `gdb_breakpoint' and
`gdb_continue_to_breakpoint' which you use but only sometimes.
* Pattern start `"\\$\[0-9\].* =' should have been more `"\\$\[0-9\]+ ='
(although it is also considered safe to use just `=').
Thanks for the pointers. I have made the changes and committed the patch.
There is now a change
KFAIL: gdb.cp/templates.exp: constructor breakpoint (PRMS: gdb/1062)
FAIL: gdb.cp/templates.exp: constructor breakpoint
although IMO the current output should be considered as PASS now.
The branch is still pretty old 126.96.36.19990127-cvs and while I would update it
but as it currently has regressions I cannot verify I would not break it.
I will update if there are no regressions now.