This is the mail archive of the archer@sourceware.org mailing list for the Archer project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [python] Fix two memory leaks


Tom Tromey wrote:
"Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:

Phil> The unicode_decref patch changes the: Phil> "python-utils.c/python_string_to_unicode" function to always return a Phil> new reference.

Could you submit this to gdb-patches? This utility code is already
there, so the fix needs to be as well. Thanks.


Done. I also committed this to the archer-tromey-python branch. The commit is:

b5235efef9aa1d619d8a5defc5aa1219dff76d3d

We should revert it should we merge master -> archer-tromey-python after this particular fix has been accepted and committed upstream.

Phil> The second patch is a straightforward addition of a variable
Phil> dereference inside the function:
Phil> "python.c/apply_val_pretty_printer". This value object was never being
Phil> dereferenced.

This is ok, thanks

Committed.


Regards

Phil


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]