This is the mail archive of the archer@sourceware.org mailing list for the Archer project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [python] Crash when using generators with Python 2.4

>>>>> "Paul" == Paul Pluzhnikov <ppluzhnikov@google.com> writes:

Paul> +  if (code)
Paul> +    {
Paul> +      PyObject *globals;
Paul> +      PyThreadState *tstate = PyThreadState_GET ();
Paul> +
Paul> +      Py_DECREF (empty_string);
Paul> +      Py_DECREF (null_tuple);

I think this may double-decref empty_string and null_tuple when
falling through to the 'failed' label.

Otherwise it looks ok to me.

Tom
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]