This is the mail archive of the archer@sourceware.org mailing list for the Archer project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] [python] Make GDB buildable on python without threads.


On Mon, Dec 15, 2008 at 4:23 PM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Paul" == Paul Pluzhnikov <ppluzhnikov@google.com> writes:
>
> Paul> This is because my Python 2.4.5 was configured with --without-threads.
>
> Is this one you built yourself?
> Or from a distro?

My distro is 32-bit, and I build 64-bit GDB, so I built this
Python myself.

> I'm curious to know how widespread this is...
>
> Paul> +#if WITH_THREAD /* If Python was built with thread support.  */
> Paul>    PyEval_ReleaseLock ();
> Paul> +#endif
>
> Instead of this, please put a new #define into python-internal.h, next
> to the others.  Thanks.

Committed as below and pushed.

Thanks,
-- 
Paul Pluzhnikov

2008-12-15  Paul Pluzhnikov  <ppluzhnikov@google.com>

       * python/python-internal.h (PyEval_ReleaseLock): New define.

diff --git a/gdb/python/python-internal.h b/gdb/python/python-internal.h
index e35d9cb..7e56784 100644
--- a/gdb/python/python-internal.h
+++ b/gdb/python/python-internal.h
@@ -55,6 +55,7 @@ typedef int Py_ssize_t;
 #define PyEval_InitThreads() 0
 #define PyThreadState_Swap(ARG) (ARG)
 #define PyEval_InitThreads() 0
+#define PyEval_ReleaseLock() 0
 #endif

 #include "command.h"


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]