This is the mail archive of the mailing list for the Archer project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [python] fix crash when manipulating string in internal variable

>>>>> "Thiago" == Thiago Jung Bauermann <> writes:

Thiago> commit b5cdb6e5cfc537b99173fe981e81a87d1ebe4566
Thiago> Author: Tom Tromey <>
Thiago> Date:   Fri Oct 17 10:50:26 2008 -0600

I only vaguely remember why I did this.  I'm glad we're sending python
patches to the list now, maybe more justifications will survive to the

I think it is this:

Thiago> I won't submit this patch upstream because I'm not sure it's
Thiago> right, since I don't know much about the implementation of
Thiago> internal variables.

It looks good to me.

It works upstream because VALUE_ADDRESS is just
value.location.address -- and copying this works as well as
copying value.location.internalvar.  This could result in a bug
if sizeof(CORE_ADDR) != sizeof(struct internalvar *).  But I doubt
that is possible.

FWIW I prefer to be pedantically correct in cases like this.  But if
you don't want to submit it on that basis, maybe I should try to get
the VALUE_ADDRESS change in upstream instead.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]