This is the mail archive of the archer@sourceware.org mailing list for the Archer project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: bokenness of nested pretty printers


On Fri, Oct 17, 2008 at 9:52 AM, Tom Tromey <tromey@redhat.com> wrote:
> Paul> If 'offset' is really necessary, then I think VALUE_ADDRESS()
> Paul> or something similar ought to add 'offset' automatically.
>
> I pushed a change to this effect.

This still wasn't quite right, as attached test case demonstrates:
now we have offset and embedded_offset added together, for a double :(

Attached patch fixes that.
Regtested on Linux/x86_64, committed and pushed.


-- 
Paul Pluzhnikov


2008-10-17  Paul Pluzhnikov  <ppluzhnikov@google.com>

	* value.c (value_from_contents_and_address): Don't
	double-count embedded_offset.
	

2008-10-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
	
	* gdb.python/python-prettyprint.exp,
	gdb.python/python-prettyprint.c,
	gdb.python/python-prettyprint.py: Add C++ tests.

Attachment: patch.txt
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]