This is the mail archive of the mailing list for the Archer project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: freshly-cut python patches

Thiago> - The order of patches doesn't look right. For instance, the
Thiago> initial pretty-printing patch comes before the types patch,
Thiago> and I believe the former actually depends on the latter.

The initial MI pretty-printing code did not depend on the types patch.
That is all changed now.

Thiago> Does pretty printing have other dependencies, like the
Thiago> symbols, symtab and block patches?

I don't believe so.  At some point the dependency is more like: is it
possible to write a useful pretty-printer without feature X?  But for
now I think all I have needed is values and types.

Thiago> I saw some fixes from you on that code, not sure if it was
Thiago> related to pretty-printing or not.

I've tried to be careful about making separate commits, but I think
there is a case or two where I didn't.  Sorry about that.

Thiago> - I'm not sure yet how to organize the pretty-printing work. A few
Thiago> commits are floating around in isolation as a result of this. Initially,
Thiago> I was thinking of having two patches: a "ground work and CLI pretty
Thiago> printing" patch and an "MI pretty printing" patch, but it would take
Thiago> some effort to make the division. Besides, you and Vladimir will
Thiago> probably have to agree anyway before submitting any of the patches, so
Thiago> there seems to be no benefit in the separation and I'm thinking of
Thiago> making only one pretty printing patch. WDYT?

Yes, I think one patch is what we should do.  The MI and CLI cases are
tied together now -- they share a good amount of code.

The pretty-printing code isn't really ready yet, though.  I am still
working on the MI bits.  Also, I think we might want to change the
auto-loading stuff a little.

I think a good candidate for the next patch would be more additions to
Value.  On the branch I added a couple methods, and these are needed
to write decent pretty-printers.  I can submit this one if you would

There are a few other things that are a bit less intertwined that we
could clean up and submit after that.  Specifically I'm thinking of
convenience functions, commands, and parameters.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]